cvm/overlay: Fix gc/startup_warnings tests#139
Merged
duanyangjing merged 2 commits intoMay 20, 2026
Merged
Conversation
Add the original JDK 8 gc/startup_warnings test file to cvm/overlay/jdk8u as the baseline for the follow-up overlay changes. This keeps the compatibility adjustments isolated in the second commit while preserving the unmodified upstream test source in the overlay history.
Adjust the TestDefaultMaxRAMFraction.java startup warning test to match the JDK17 hotspot behavior while keeping the changes isolated under the JDK 8 overlay. - TestDefaultMaxRAMFraction.java: JDK 17 still warns for DefaultMaxRAMFraction, but the warning is emitted by the JDK17 hotspot deprecation path with different wording; update the expected text to the JDK17 hotspot message.
superajun-wsj
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDefaultMaxRAMFraction.java: JDK 17 still warns for DefaultMaxRAMFraction, but the warning is emitted by the JDK17 hotspot deprecation path with different wording; update the expected text to the JDK17 hotspot message.
Other tests have options removed in JDK 17, so keep them excluded