Add default domain suffix database path#2705
Open
BharatDeva wants to merge 1 commit into
Open
Conversation
DomainSuffixExpertBot had no default suffix_file even though its update-database command can create and refresh the public suffix list file. Use a stable state-file path by default and let update_database fall back to it when runtime parameters omit suffix_file. Add a regression test covering that default update path. Signed-off-by: BharatDeva <278575558+BharatDeva@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2688
Description
DomainSuffixExpertBotdid not define a defaultsuffix_file, so the bot and its--update-databasepath depended on every runtime configuration providing that parameter explicitly.This change adds a stable default under IntelMQ's state directory and lets
update_database()use that default when a domain suffix bot is configured without asuffix_fileparameter. Existing configured paths still take precedence.Tests
I ran the focused regression test and the domain suffix test module under WSL: