From 612492a572377f841f36a3fc8c4261627ff071a6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20S=C3=A1=20de=20Mello?= <codasm@pm.me>
Date: Sun, 26 Jul 2026 12:23:03 +0100
Subject: [PATCH] Fix broken/stale intra-doc links and export ReplaceError

- crate::asign typo -> crate::assign in the lib.rs doc-link table
- RFC 6091 -> RFC 6901 typo, and a doc comment that used `//`
  instead of `///` and was silently dropped from rendered docs
- toml docs.rs links pointed at 0.8, dependency is now 0.9
- ReplaceError (returned by PointerBuf::replace) was pub but never
  re-exported from the crate root, since `mod pointer` is private -
  callers had no way to name the type. Added it to the top-level
  `pub use`.
- assorted unresolved/redundant intra-doc links in resolve.rs and
  diagnostic.rs (Index, Subject, PointerBuf::parse, ParseError)

Verified with cargo doc --all-features (0 warnings, was 8),
cargo test --all-features, and cargo clippy --all-features --all-targets.
---
 README.md         | 4 ++--
 src/diagnostic.rs | 6 +++---
 src/lib.rs        | 8 ++++----
 src/pointer.rs    | 4 ++--
 src/resolve.rs    | 6 +++---
 5 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/README.md b/README.md
index 700131e..0811197 100644
--- a/README.md
+++ b/README.md
@@ -234,7 +234,7 @@ dual licensed as above, without any additional terms or conditions.
 [`serde`]: https://docs.rs/serde/1.0/serde/index
 [`serde_json`]: https://docs.rs/serde_json/1.0/serde_json/enum.Value.html
 [`serde_json::Value`]: https://docs.rs/serde_json/1.0/serde_json/enum.Value.html
-[`toml`]: https://docs.rs/toml/0.8/toml/enum.Value.html
-[`toml::Value`]: https://docs.rs/toml/0.8/toml/enum.Value.html
+[`toml`]: https://docs.rs/toml/0.9/toml/enum.Value.html
+[`toml::Value`]: https://docs.rs/toml/0.9/toml/enum.Value.html
 [`Path`]: https://doc.rust-lang.org/std/path/struct.Path.html
 [`PathBuf`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html
diff --git a/src/diagnostic.rs b/src/diagnostic.rs
index 086cb69..e909dbc 100644
--- a/src/diagnostic.rs
+++ b/src/diagnostic.rs
@@ -17,7 +17,7 @@ pub trait Diagnostic: Sized {
     /// The docs.rs URL for this error
     fn url() -> &'static str;
 
-    /// Returns the label for the given [`Subject`] if applicable.
+    /// Returns the label for the given [`Subject`](Diagnostic::Subject) if applicable.
     fn labels(&self, subject: &Self::Subject) -> Option<Box<dyn Iterator<Item = Label>>>;
 }
 
@@ -51,8 +51,8 @@ impl From<Label> for miette::LabeledSpan {
 ///
 /// This type serves two roles:
 ///
-/// 1. **[`PointerBuf::parse`]**: Captures the [`ParseError`] along with the
-///    input `String`.
+/// 1. **[`PointerBuf::parse`](crate::PointerBuf::parse)**: Captures the
+///    [`ParseError`](crate::ParseError) along with the input `String`.
 ///
 /// 2. **Reporting:** Provides enriched reporting capabilities, including
 ///    (optional) `miette` integration, for `ParseError` and associated  errors
diff --git a/src/lib.rs b/src/lib.rs
index 8200bd0..796fd0f 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -19,7 +19,7 @@
 //! [`tokens`]: crate::Pointer::tokens
 //! [`components`]: crate::Pointer::components
 //! [`resolve`]: crate::resolve
-//! [`assign`]: crate::asign
+//! [`assign`]: crate::assign
 //! [`delete`]: crate::delete
 //! [`Resolve`]: crate::resolve::Resolve
 //! [`ResolveMut`]: crate::resolve::ResolveMut
@@ -28,8 +28,8 @@
 //! [`serde`]: https://docs.rs/serde/1.0/serde/index
 //! [`serde_json`]: https://docs.rs/serde_json/1.0/serde_json/enum.Value.html
 //! [`serde_json::Value`]: https://docs.rs/serde_json/1.0/serde_json/enum.Value.html
-//! [`toml`]: https://docs.rs/toml/0.8/toml/enum.Value.html
-//! [`toml::Value`]: https://docs.rs/toml/0.8/toml/enum.Value.html
+//! [`toml`]: https://docs.rs/toml/0.9/toml/enum.Value.html
+//! [`toml::Value`]: https://docs.rs/toml/0.9/toml/enum.Value.html
 //! [`Path`]: https://doc.rust-lang.org/std/path/struct.Path.html
 //! [`PathBuf`]: https://doc.rust-lang.org/std/path/struct.PathBuf.html
 
@@ -67,7 +67,7 @@ pub mod diagnostic;
 pub use diagnostic::{Diagnose, Report};
 
 mod pointer;
-pub use pointer::{ParseError, Pointer, PointerBuf, RichParseError};
+pub use pointer::{ParseError, Pointer, PointerBuf, ReplaceError, RichParseError};
 
 mod token;
 pub use token::{EncodingError, InvalidEncoding, Token, Tokens};
diff --git a/src/pointer.rs b/src/pointer.rs
index 003d5ea..887dd49 100644
--- a/src/pointer.rs
+++ b/src/pointer.rs
@@ -568,10 +568,10 @@ impl Pointer {
         buf
     }
 
-    //  Returns the length of `self` in encoded format.
+    /// Returns the length of `self` in encoded format.
     ///
     /// This length expresses the byte count of the underlying string that
-    /// represents the RFC 6091 Pointer. See also [`std::str::len`].
+    /// represents the RFC 6901 Pointer. See also [`str::len`].
     ///
     /// ## Examples
     /// ```
diff --git a/src/resolve.rs b/src/resolve.rs
index 3cf6ff4..a7f8c5a 100644
--- a/src/resolve.rs
+++ b/src/resolve.rs
@@ -9,7 +9,7 @@
 //! ## Usage
 //! [`Resolve`] and [`ResolveMut`] can be used directly or through the
 //! [`resolve`](Pointer::resolve) and [`resolve_mut`](Pointer::resolve_mut)
-//! methods on [`Pointer`] and [`PointerBuf`](crate::PointerBuf).
+//! methods on [`Pointer`] and [`PointerBuf`].
 //!
 //! ```rust
 //! use jsonptr::{Pointer, Resolve, ResolveMut};
@@ -106,8 +106,8 @@ pub enum Error {
         source: ParseIndexError,
     },
 
-    /// A [`Token`] within the [`Pointer`] contains an [`Index`] which is out of
-    /// bounds.
+    /// A [`Token`] within the [`Pointer`] contains an
+    /// [`Index`](crate::index::Index) which is out of bounds.
     ///
     /// ## Example
     /// ```rust