Skip to content

refactor(cli): use adaptive table formatter broadly#1333

Merged
thebiglabasky merged 7 commits into
mainfrom
herve/adaptive-table-formatters-sweep
Jun 8, 2026
Merged

refactor(cli): use adaptive table formatter broadly#1333
thebiglabasky merged 7 commits into
mainfrom
herve/adaptive-table-formatters-sweep

Conversation

@thebiglabasky

Copy link
Copy Markdown
Contributor

Summary

  • Migrate remaining user-facing formatter tables to renderAdaptiveTable(...).
  • Remove formatter-local terminal width math, fixed-width calculations, and repeated per-cell truncation.
  • Update affected formatter snapshots for the natural adaptive spacing changes.

Why

PR #1326 added the shared adaptive table utility. This pass applies it broadly so table layout behavior lives in one renderer instead of each command carrying brittle terminal-width logic.

Validation

  • pnpm exec vitest run src/formatters/__tests__/render.spec.ts src/formatters/__tests__/checks.spec.ts src/formatters/__tests__/test-sessions.spec.ts src/formatters/__tests__/status-pages.spec.ts src/formatters/__tests__/account-members.spec.ts src/formatters/__tests__/account-plan.spec.ts src/formatters/__tests__/incidents.spec.ts src/formatters/__tests__/analytics.spec.ts
  • pnpm --filter checkly exec tsc -p tsconfig.json --skipLibCheck
  • pnpm exec eslint packages/cli/src/formatters/account-members.ts packages/cli/src/formatters/account-plan.ts packages/cli/src/formatters/batch-stats.ts packages/cli/src/formatters/checks.ts packages/cli/src/formatters/incidents.ts packages/cli/src/formatters/status-pages.ts packages/cli/src/formatters/test-sessions.ts
  • git diff --check

@thebiglabasky thebiglabasky marked this pull request as ready for review May 29, 2026 13:47
@thebiglabasky thebiglabasky requested a review from martzoukos June 4, 2026 14:11
martzoukos
martzoukos previously approved these changes Jun 8, 2026

@martzoukos martzoukos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

thebiglabasky and others added 2 commits June 8, 2026 12:27
…formatters-sweep

# Conflicts:
#	packages/cli/src/formatters/account-members.ts
#	packages/cli/src/formatters/alert-channels.ts
#	packages/cli/src/formatters/batch-stats.ts
#	packages/cli/src/formatters/checks.ts
#	packages/cli/src/formatters/status-pages.ts
@thebiglabasky thebiglabasky merged commit 633a7ed into main Jun 8, 2026
8 checks passed
@thebiglabasky thebiglabasky deleted the herve/adaptive-table-formatters-sweep branch June 8, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants