Fix php 8.4 deprecations#33
Conversation
…ly treated as a required parameter
|
If you want to keep the compatibility with php >= 5.3, I believe the parameter types need to be removed. Let me know what you want to do. |
cseufert
left a comment
There was a problem hiding this comment.
Looks good
I think a v2.0 release would be warranted, and make minimum PHP version >= 7.1
|
Hi Christian, I hope you’re doing well. I just wanted to kindly follow up on this pull request, which addresses PHP 8.4 deprecations and has been pending for a while. It’s now been about 10 months since it was submitted, and given how active you’ve been on GitHub, I wanted to check if you could find some time to review it. This fix would really help keep the package compatible for users upgrading to the latest PHP versions. Since I’ve sponsored your work in the past and value the package a lot, I’d greatly appreciate it if you could take a look or let us know if you’d prefer someone else to help maintain compatibility updates. |
|
bump since php 8.5 got released. |
Thank you for the package which I enjoy using in my projects. Here's a small contribution towards the package maintenance.