Found by builder bugfix-1264 while writing regression tests for PR #1266: several pre-existing reconnect tests (a) wrap their assertions in if (client) guards and (b) pass Date.now() as the shellper process start time, which never matches the real one — so the test bodies silently never run. They pass while testing nothing.
Audit the reconnect test files, make the guards hard failures (or proper skips), and drive the real reconnect path. Related cautionary tale in the PR #1266 thread: a regression test that asserts on a hand-built object literal without calling the code under test passes against buggy code — false confidence. The reconnect suite should be checked for that pattern too.
Found by builder bugfix-1264 while writing regression tests for PR #1266: several pre-existing reconnect tests (a) wrap their assertions in
if (client)guards and (b) passDate.now()as the shellper process start time, which never matches the real one — so the test bodies silently never run. They pass while testing nothing.Audit the reconnect test files, make the guards hard failures (or proper skips), and drive the real reconnect path. Related cautionary tale in the PR #1266 thread: a regression test that asserts on a hand-built object literal without calling the code under test passes against buggy code — false confidence. The reconnect suite should be checked for that pattern too.