Skip to content

Commit a1f027b

Browse files
committed
fix: document best-effort log chmod
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
1 parent 26aada4 commit a1f027b

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

system/Log/Handlers/FileHandler.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
/**
2020
* Log error messages to file system
2121
*
22-
* @see \CodeIgniter\Log\Handlers\FileHandlerTest
22+
* @see FileHandlerTest
2323
*/
2424
class FileHandler extends BaseHandler
2525
{
@@ -121,6 +121,7 @@ public function handle($level, $message): bool
121121
fclose($fp);
122122

123123
if ($newfile) {
124+
// The log entry is already persisted - permission changes are best-effort.
124125
@chmod($filepath, $this->filePermissions);
125126
}
126127

0 commit comments

Comments
 (0)