valueflow.cpp: avoid unnecessary copies in valueFlowInferCondition()

firewave · firewave · commit 6aa0173caf8d · 2026-05-04T09:52:33.000+02:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -5075,7 +5075,7 @@ static void valueFlowInferCondition(TokenList& tokenlist, const Settings& settin
                 for (const ValuePtr<InferModel>& model : iteratorModels) {
                     std::vector<ValueFlow::Value> result =
                         infer(model, tok->str(), tok->astOperand1()->values(), tok->astOperand2()->values());
-                    for (ValueFlow::Value value : result) {
+                    for (ValueFlow::Value& value : result) {
                         value.valueType = ValueFlow::Value::ValueType::INT;
                         setTokenValue(tok, std::move(value), settings);
                     }

Original file line number	Diff line number	Diff line change
`@@ -5075,7 +5075,7 @@ static void valueFlowInferCondition(TokenList& tokenlist, const Settings& settin`
`5075`	`5075`	`for (const ValuePtr<InferModel>& model : iteratorModels) {`
`5076`	`5076`	`std::vector<ValueFlow::Value> result =`
`5077`	`5077`	`infer(model, tok->str(), tok->astOperand1()->values(), tok->astOperand2()->values());`
`5078`		`- for (ValueFlow::Value value : result) {`
	`5078`	`+ for (ValueFlow::Value& value : result) {`
`5079`	`5079`	`value.valueType = ValueFlow::Value::ValueType::INT;`
`5080`	`5080`	`setTokenValue(tok, std::move(value), settings);`
`5081`	`5081`	`}`