valueflow.cpp: avoid unnecessary copies in valueFlowFunctionReturn()

firewave · firewave · commit a0e1e5eb6129 · 2026-06-23T09:21:09.000+02:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -5886,10 +5886,10 @@ static void valueFlowFunctionReturn(TokenList& tokenlist, ErrorLogger& errorLogg
         if (programMemory.empty() && !arguments.empty())
             continue;
         std::vector<ValueFlow::Value> values = execute(function->functionScope, programMemory, settings);
-        for (const ValueFlow::Value& v : values) {
+        for (ValueFlow::Value& v : values) {
             if (v.isUninitValue())
                 continue;
-            setFunctionReturnValue(function, tok, v, settings);
+            setFunctionReturnValue(function, tok, std::move(v), settings);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -5886,10 +5886,10 @@ static void valueFlowFunctionReturn(TokenList& tokenlist, ErrorLogger& errorLogg`
`5886`	`5886`	`if (programMemory.empty() && !arguments.empty())`
`5887`	`5887`	`continue;`
`5888`	`5888`	`std::vector<ValueFlow::Value> values = execute(function->functionScope, programMemory, settings);`
`5889`		`- for (const ValueFlow::Value& v : values) {`
	`5889`	`+ for (ValueFlow::Value& v : values) {`
`5890`	`5890`	`if (v.isUninitValue())`
`5891`	`5891`	`continue;`
`5892`		`- setFunctionReturnValue(function, tok, v, settings);`
	`5892`	`+ setFunctionReturnValue(function, tok, std::move(v), settings);`
`5893`	`5893`	`}`
`5894`	`5894`	`}`
`5895`	`5895`	`}`