Added missing try-catch

Author: Ante-Koceic

apps/contact/helpers/notion.ts

@@ -141,6 +141,7 @@ export const createContact = async (
         url: pageUrl,
       };
     }
+    console.error("Notion hepler => Failed to create notion page");
     return {
       error: "Failed to create notion page",
     };

apps/contact/helpers/slack.test.ts

@@ -43,7 +43,7 @@ describe("Slack Helper", () => {
     email: "john@example.com",
     url: "https://notion.so/test",
   };
-  const errorMessage = "Error message";
+  const userMessage = "Test message";
   describe("notifyContactCreated", async () => {
     it("should send message on slack", async () => {
       await notifyContactCreated(
@@ -57,7 +57,7 @@ describe("Slack Helper", () => {
       expect(fetchCalls[0].init.body).toContain(validContactData.name);
       expect(fetchCalls[0].init.body).toContain(validContactData.email);
       expect(fetchCalls[0].init.body).toContain(validContactData.url);
-      expect(fetchCalls[0].init.body).not.toContain(errorMessage);
+      expect(fetchCalls[0].init.body).not.toContain(userMessage);
     });
   });
 
@@ -66,15 +66,15 @@ describe("Slack Helper", () => {
       await notifyContactError(
         validContactData.name,
         validContactData.email,
-        errorMessage,
+        userMessage,
       );
 
       expect(fetchCalls.length).toBe(1);
       expect(fetchCalls[0].url).toBe("https://slack.com/api/chat.postMessage");
       expect(fetchCalls[0].init.body).toContain(validContactData.name);
       expect(fetchCalls[0].init.body).toContain(validContactData.email);
       expect(fetchCalls[0].init.body).not.toContain(validContactData.url);
-      expect(fetchCalls[0].init.body).toContain(errorMessage);
+      expect(fetchCalls[0].init.body).toContain(userMessage);
     });
   });
 });

apps/contact/helpers/slack.ts

@@ -75,19 +75,23 @@ export const notifyContactCreated = async (
   const payload = createPayload(name, email, url);
   const payloadStringify = JSON.stringify(payload);
 
-  const result = await fetch("https://slack.com/api/chat.postMessage", {
-    method: "POST",
-    body: payloadStringify,
-    headers: {
-      "Content-Type": "application/json; charset=utf-8",
-      "Content-Length": payloadStringify.length.toString(),
-      Authorization: `Bearer ${SLACK_BOT_TOKEN}`,
-      Accept: "application/json",
-    },
-  });
-  const realResponse = await result.json();
-  if (result.status !== 200 || !realResponse.ok) {
-    console.error("Could not send notification message to Slack");
+  try {
+    const result = await fetch("https://slack.com/api/chat.postMessage", {
+      method: "POST",
+      body: payloadStringify,
+      headers: {
+        "Content-Type": "application/json; charset=utf-8",
+        "Content-Length": payloadStringify.length.toString(),
+        Authorization: `Bearer ${SLACK_BOT_TOKEN}`,
+        Accept: "application/json",
+      },
+    });
+    const realResponse = await result.json();
+    if (result.status !== 200 || !realResponse.ok) {
+      console.error("Could not send notification message to Slack");
+    }
+  } catch (error) {
+    console.error("Could not send notification message to Slack", error);
   }
 };
 
@@ -99,18 +103,22 @@ export const notifyContactError = async (
   const payload = createErrorPayload(name, email, content);
   const payloadStringify = JSON.stringify(payload);
 
-  const result = await fetch("https://slack.com/api/chat.postMessage", {
-    method: "POST",
-    body: payloadStringify,
-    headers: {
-      "Content-Type": "application/json; charset=utf-8",
-      "Content-Length": payloadStringify.length.toString(),
-      Authorization: `Bearer ${SLACK_BOT_TOKEN}`,
-      Accept: "application/json",
-    },
-  });
-  const realResponse = await result.json();
-  if (result.status !== 200 || !realResponse.ok) {
-    console.error("Could not send notification message to Slack");
+  try {
+    const result = await fetch("https://slack.com/api/chat.postMessage", {
+      method: "POST",
+      body: payloadStringify,
+      headers: {
+        "Content-Type": "application/json; charset=utf-8",
+        "Content-Length": payloadStringify.length.toString(),
+        Authorization: `Bearer ${SLACK_BOT_TOKEN}`,
+        Accept: "application/json",
+      },
+    });
+    const realResponse = await result.json();
+    if (result.status !== 200 || !realResponse.ok) {
+      console.error("Could not send notification message to Slack");
+    }
+  } catch (error) {
+    console.error("Could not send notification message to Slack", error);
   }
 };