Simplify create-batch: replace --replication with repeatable --deal-type (#652)

## Summary

- Replace `--replication dealType=count` flag with simpler repeatable
`--deal-type` flag (market, pdp, ddo) on `create-batch`
- Per-provider differentiation is expressed by running separate
`create-batch` commands with different `--group` labels
- Bump go-synapse to latest (`v0.0.0-20260326143334-8c86c7fc3b17`)
- Update CLI reference docs and guides to match

Per discussion on #651 — this is a simpler UX that avoids encoding
counts in a single invocation while preserving the cross-product
semantics.

## Test plan

- [x] `go build ./...` — compiles clean
- [x] `go vet ./...` — no issues
- [x] `go test ./handler/deal/schedule/...` — passes

---------

Co-authored-by: Arkadiy Kukarkin <parkan@gmail.com>

Author: anjor

cmd/deal/schedule/create_batch.go

@@ -1,10 +1,7 @@
 package schedule
 
 import (
-	"fmt"
 	"slices"
-	"strconv"
-	"strings"
 
 	"github.com/cockroachdb/errors"
 	"github.com/data-preservation-programs/singularity/cmd/cliutil"
@@ -18,14 +15,22 @@ import (
 var CreateBatchCmd = &cli.Command{
 	Name:  "create-batch",
 	Usage: "Create the cross-product of schedules for multiple preparations and providers",
-	Description: `Create all schedules for preparations x providers x replication policy.
+	Description: `Create all schedules for preparations x providers x deal types.
 
 Examples:
+  # Cold DDO copies to 2 providers
   singularity deal schedule create-batch \
-    --group dataset-a \
+    --group dataset-a-cold \
     --preparation prep-a --preparation prep-b \
     --provider f01000 --provider f02000 \
-    --replication market=1 --replication pdp=1
+    --deal-type ddo
+
+  # Warm + cold to 1 provider
+  singularity deal schedule create-batch \
+    --group dataset-a-warm \
+    --preparation prep-a \
+    --provider f03000 \
+    --deal-type ddo --deal-type pdp
 `,
 	Flags: append([]cli.Flag{
 		&cli.StringSliceFlag{
@@ -39,10 +44,9 @@ Examples:
 			Required: true,
 		},
 		&cli.StringSliceFlag{
-			Name:     "replication",
-			Category: "Batching",
-			Usage:    "Replication policy entry in dealType=count form, e.g. market=1 or pdp=2. Repeat this flag.",
-			Value:    cli.NewStringSlice(fmt.Sprintf("%s=1", model.DealTypeMarket)),
+			Name:  "deal-type",
+			Usage: "Deal types to create schedules for: market, pdp, or ddo. Repeat for multiple types.",
+			Value: cli.NewStringSlice(string(model.DealTypeMarket)),
 		},
 	}, scheduleCreateFlags(false)...),
 	Action: func(c *cli.Context) error {
@@ -59,9 +63,9 @@ Examples:
 			return errors.New("at least one provider is required")
 		}
 
-		replicationPolicy, err := parseReplicationPolicy(c.StringSlice("replication"))
+		dealTypes, err := parseDealTypes(c.StringSlice("deal-type"))
 		if err != nil {
-			return errors.WithStack(err)
+			return err
 		}
 
 		db, closer, err := database.OpenFromCLI(c)
@@ -76,10 +80,10 @@ Examples:
 		}
 
 		lotusClient := util.NewLotusClient(c.String("lotus-api"), c.String("lotus-token"))
-		created := make([]model.Schedule, 0, len(preparations)*len(providers)*len(replicationPolicy))
+		created := make([]model.Schedule, 0, len(preparations)*len(dealTypes)*len(providers))
 
 		for _, preparation := range preparations {
-			for _, dealType := range replicationPolicy {
+			for _, dealType := range dealTypes {
 				for _, provider := range providers {
 					request := createRequest(c, preparation, provider, string(dealType), allowedPieceCIDs)
 					schedule, err := handlerschedule.Default.CreateHandler(c.Context, db, lotusClient, request)
@@ -97,28 +101,17 @@ Examples:
 	},
 }
 
-func parseReplicationPolicy(values []string) ([]model.DealType, error) {
-	policy := make([]model.DealType, 0)
-	for _, value := range values {
-		parts := strings.SplitN(strings.TrimSpace(value), "=", 2)
-		if len(parts) != 2 {
-			return nil, errors.Newf("invalid replication policy entry %q: expected dealType=count", value)
-		}
-
-		dealType := model.DealType(strings.TrimSpace(parts[0]))
-		if !slices.Contains(model.DealTypes, dealType) {
-			return nil, errors.Newf("invalid replication deal type %q", dealType)
-		}
-
-		count, err := strconv.Atoi(strings.TrimSpace(parts[1]))
-		if err != nil || count < 1 {
-			return nil, errors.Newf("invalid replication count %q", parts[1])
-		}
-
-		for i := 0; i < count; i++ {
-			policy = append(policy, dealType)
+func parseDealTypes(values []string) ([]model.DealType, error) {
+	dealTypes := make([]model.DealType, 0, len(values))
+	for _, v := range values {
+		dt := model.DealType(v)
+		if !slices.Contains(model.DealTypes, dt) {
+			return nil, errors.Newf("invalid deal type %q: must be one of market, pdp, ddo", v)
 		}
+		dealTypes = append(dealTypes, dt)
 	}
-
-	return policy, nil
+	if len(dealTypes) == 0 {
+		return nil, errors.New("at least one deal type is required")
+	}
+	return dealTypes, nil
 }

docs/en/cli-reference/deal/schedule/create-batch.md

@@ -45,25 +45,35 @@ singularity deal schedule create -h
 
 ## Batch schedule creation
 
-When you need to replicate multiple preparations across multiple storage providers with a defined replication policy, use `create-batch` to generate all schedules in one command:
+When you need to replicate multiple preparations across multiple storage providers, use `create-batch` to generate all schedules in one command:
 
 ```sh
+# Cold DDO copies to 2 providers
 singularity deal schedule create-batch \
-  --group my-dataset \
+  --group dataset-a-cold \
   --preparation prep-a --preparation prep-b \
   --provider f01000 --provider f02000 \
-  --replication market=1 --replication pdp=1
+  --deal-type ddo
+
+# Warm + cold to 1 provider
+singularity deal schedule create-batch \
+  --group dataset-a-warm \
+  --preparation prep-a \
+  --provider f03000 \
+  --deal-type ddo --deal-type pdp
 ```
 
-This creates the full cross-product: for each preparation, for each deal type in the replication policy, a schedule is created for every provider. The example above produces 8 schedules (2 preparations x 2 deal types x 2 providers).
+This creates the full cross-product: for each preparation, for each deal type, a schedule is created for every provider. The first example produces 4 schedules (2 preparations x 1 deal type x 2 providers). The second produces 2 schedules (1 preparation x 2 deal types x 1 provider).
+
+### Deal types
 
-### Replication policy
+The `--deal-type` flag specifies which deal types to create. Repeat for multiple types:
 
-The `--replication` flag specifies deal types and how many schedules of that type to create per provider per preparation:
+- `market` — legacy f05 market deal (default)
+- `pdp` — PDP (Proof of Data Possession) deal
+- `ddo` — DDO (Decentralized Data Onboarding) allocation
 
-- `market=1` — one legacy market deal schedule
-- `pdp=2` — two PDP deal schedules
-- `ddo=1` — one DDO allocation schedule
+To express per-provider differentiation (e.g., some providers get cold copies only, one gets warm + cold), run separate `create-batch` commands with different groups.
 
 ### Group labels
 

docs/en/deal-making/create-a-deal-schedule.md

@@ -123,14 +123,14 @@ Expected state flow:
 
 ## Batch DDO schedules
 
-To schedule DDO deals across multiple preparations and providers in one command, use `create-batch` with `--replication ddo=1`:
+To schedule DDO deals across multiple preparations and providers in one command, use `create-batch` with `--deal-type ddo`:
 
 ```bash
 singularity deal schedule create-batch \
   --group my-ddo-dataset \
   --preparation prep-a --preparation prep-b \
   --provider t01000 --provider t02000 \
-  --replication ddo=1 \
+  --deal-type ddo \
   --url-template "https://downloads.example.com/piece/{PIECE_CID}.car"
 ```
 

docs/en/topics/ddo-contract-deal-guide.md

@@ -8,7 +8,7 @@ require (
 	github.com/bcicen/jstream v1.0.1
 	github.com/brianvoe/gofakeit/v6 v6.23.2
 	github.com/cockroachdb/errors v1.11.3
-	github.com/data-preservation-programs/go-synapse v0.0.0-20260310124115-0faeb6924d36
+	github.com/data-preservation-programs/go-synapse v0.0.0-20260326143334-8c86c7fc3b17
 	github.com/data-preservation-programs/table v0.0.3
 	github.com/dustin/go-humanize v1.0.1
 	github.com/ethereum/go-ethereum v1.14.12

go.mod

@@ -275,8 +275,8 @@ github.com/cronokirby/saferith v0.33.0 h1:TgoQlfsD4LIwx71+ChfRcIpjkw+RPOapDEVxa+
 github.com/cronokirby/saferith v0.33.0/go.mod h1:QKJhjoqUtBsXCAVEjw38mFqoi7DebT7kthcD7UzbnoA=
 github.com/cskr/pubsub v1.0.2 h1:vlOzMhl6PFn60gRlTQQsIfVwaPB/B/8MziK8FhEPt/0=
 github.com/cskr/pubsub v1.0.2/go.mod h1:/8MzYXk/NJAz782G8RPkFzXTZVu63VotefPnR9TIRis=
-github.com/data-preservation-programs/go-synapse v0.0.0-20260310124115-0faeb6924d36 h1:NJ1jwnGQ+IIWMIKgfatmXVjYIH3krCV4fO/29nED6BI=
-github.com/data-preservation-programs/go-synapse v0.0.0-20260310124115-0faeb6924d36/go.mod h1:qgzPsiGWjTPT/oACA6Uj1+WsASwsYFW/iJ8AWacJdjc=
+github.com/data-preservation-programs/go-synapse v0.0.0-20260326143334-8c86c7fc3b17 h1:pTOIdr5W7pHrxFaQdONxHWiCtIOgdc6zfKL82SS4xhI=
+github.com/data-preservation-programs/go-synapse v0.0.0-20260326143334-8c86c7fc3b17/go.mod h1:qgzPsiGWjTPT/oACA6Uj1+WsASwsYFW/iJ8AWacJdjc=
 github.com/data-preservation-programs/table v0.0.3 h1:hboeauxPXybE8KlMA+RjDXz/J4xaG5CAFCcxyOm8yWo=
 github.com/data-preservation-programs/table v0.0.3/go.mod h1:sRGP/IuuqFc/y9QfmDyb5h6Q2wrnhhnBofEOj9aDRJg=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=