Skip to content

Commit 0fe609c

Browse files
committed
[SEA-NodeJS] rename misses from thorough review: use_sea→use_kernel, README SeaNativeLoader→KernelNativeLoader
Caught by a file-by-file pass (not grep-pattern matching): - use_sea (snake_case Python flag) in 2 comments → use_kernel (matches the Python connector renamed flag); the camelCase useSEA sed had missed snake_case. - native/kernel/README.md referenced SeaNativeLoader → KernelNativeLoader (the README is a committed doc, not regenerated by build:native). Co-authored-by: Isaac Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
1 parent 01f1517 commit 0fe609c

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

lib/DBSQLClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ export default class DBSQLClient extends EventEmitter implements IDBSQLClient, I
628628
this.connectionProvider = this.createConnectionProvider(options);
629629

630630
// M0: `useKernel` is consumed via a non-exported internal-options cast so it
631-
// doesn't ship in the public `.d.ts`. Mirrors Python's `kwargs.get("use_sea")`
631+
// doesn't ship in the public `.d.ts`. Mirrors Python's `kwargs.get("use_kernel")`
632632
// pattern (see databricks-sql-python/src/databricks/sql/session.py).
633633
const internalOptions = options as ConnectionOptions & InternalConnectionOptions;
634634
const backend = internalOptions.useKernel

lib/contracts/InternalConnectionOptions.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
* Internal, non-exported extension of `ConnectionOptions`. Carries M0-only
33
* flags that should not appear in the published `.d.ts`.
44
*
5-
* Matches the Python connector pattern: there, `use_sea` is consumed via
6-
* `kwargs.get("use_sea", False)` and is intentionally absent from the typed
5+
* Matches the Python connector pattern: there, `use_kernel` is consumed via
6+
* `kwargs.get("use_kernel", False)` and is intentionally absent from the typed
77
* signature (see `databricks-sql-python/src/databricks/sql/session.py`).
88
*
99
* Callers cast `ConnectionOptions` to this type *only* at the read site

native/kernel/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# `native/sea/` — consumer-side directory for the Rust napi binding
1+
# `native/kernel/` — consumer-side directory for the Rust napi binding
22

33
**The Rust binding source lives in the kernel repo** at
44
`databricks-sql-kernel/napi/`. Building it requires a local checkout
@@ -27,7 +27,7 @@ and reintroduce the same clash. Standalone-workspace is the fix.
2727

2828
## What lives in this directory
2929

30-
- `index.d.ts` — TypeScript declarations consumed by `lib/sea/`.
30+
- `index.d.ts` — TypeScript declarations consumed by `lib/kernel/`.
3131
Generated by napi-rs from the Rust source; checked in as the
3232
consumer-facing type contract.
3333
- `index.js` — napi-rs's per-platform router shim. Gitignored;
@@ -57,7 +57,7 @@ nodejs repo.
5757

5858
At release time the kernel's CI publishes
5959
`@databricks/databricks-sql-kernel-<triple>` npm packages — one per supported
60-
platform — each containing a single `.node` binary. `native/sea/index.js`
60+
platform — each containing a single `.node` binary. `native/kernel/index.js`
6161
(the napi-rs router) `require()`s the package matching the consumer's
6262
`process.platform` / `process.arch` at load time.
6363

@@ -77,7 +77,7 @@ M0 targets a **single** triple: **`linux-x64-gnu`** (package
7777
`@databricks/databricks-sql-kernel-linux-x64-gnu`, once published).
7878

7979
On every other platform (macOS, Windows, linux-arm64, linux-x64-musl
80-
/ Alpine, …) the SEA binding is simply absent: `SeaNativeLoader`
80+
/ Alpine, …) the kernel binding is simply absent: `KernelNativeLoader`
8181
returns `undefined` from `tryGet()` / throws a structured
8282
`MODULE_NOT_FOUND` hint from `get()`, and the driver continues to use
8383
the Thrift backend exclusively. This is expected, not a regression —

0 commit comments

Comments
 (0)