fix: made tests os dependent#456
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestAppDataDir_Linuxwas running on all platforms and failing on darwin because it asserts Linux-specific paths (/xdg/home/...,/home/user/.kiji-proxy,/var/lib/kiji-proxy) againstAppDataDir(), which short-circuits to~/Library/Application Support/Kiji Privacy Proxyon darwin.paths_test.go→paths_linux_test.goso Go's filename-based build constraint scopes the test to Linux only — no//go:buildtag needed.paths_darwin_test.goso the darwin branch ofAppDataDir()(previously uncovered) is exercised on macOS hosts.No behavior change in
paths.go; this is test hygiene only.Test plan
go test ./src/backend/paths/...passes on darwin (runsTestAppDataDir_Darwin, skips Linux test via filename).GOOS=linux go vet ./src/backend/paths/...clean — Linux build still includes the original test.make test-gopasses end-to-end on darwin.TestAppDataDir_Linuxstill runs and passes on the Linux runner.