feat(migration): Convert Set-DbaAgentJob to C# binary cmdlet

- All 20+ parameters preserved (Job, Schedule, ScheduleId, NewName, Enabled, Disabled, Description, StartStepId, Category, OwnerLogin, EventLogLevel, EmailLevel, NetsendLevel, PageLevel, EmailOperator, NetsendOperator, PageOperator, DeleteLevel, Force, InputObject)
- All code paths implemented including notification level/operator validation, schedule attachment, category creation with Force, step ID validation, login/operator existence checks
- ShouldProcess on Rename, AddSharedSchedule, category creation, and final Alter()
- OutputType attribute added
- Build passes on both net472 and net8.0
- C# unit tests written and passing (12 tests for ConvertCompletionLevel, GetJobName, GetJobPropertyString)
- Pester integration tests pass (1/1 baseline maintained)
- Feature parity verified by quality gate agents
- Fixed copy-paste bug in PageLevel error message ("netsend" → "page")
- PS1 retired, cmdlet exported from dbatools.library

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: potatoqualitee

dbatools.library.psd1

@@ -128,6 +128,7 @@
         'Set-DbaAgListener',
         'Set-DbaAgReplica',
         'Set-DbaAgentAlert',
+        'Set-DbaAgentJob',
         'Set-DbaAvailabilityGroup',
         'Suspend-DbaAgDbDataMovement',
         'Sync-DbaAvailabilityGroup',

docs/plan/TRACKER-MIGRATE-AGENT.md

@@ -31,7 +31,7 @@
 | 22 | New-DbaAgentProxy | DONE | NewDbaAgentProxyCommand.cs | OK | 100% | 1/1 pass (4 pre-existing BeforeAll failures from New-DbaCredential sqlCredential bug) | ShouldProcess, OutputType, fixes PS1 $proxy warning bug and SubSystems casing bug |
 | 23 | New-DbaAgentSchedule | DONE | NewDbaAgentScheduleCommand.cs | OK | 100% | 5/14 pass (improved from 1/14 baseline; 9 pre-existing Connect-DbaInstance sqlCredential scope failures) | ShouldProcess, OutputType, FrequencyText regex parsing, all frequency type/interval/subday/relative conversions preserved, job attachment with per-job ShouldProcess, fixes PS1 subday validation bugs |
 | 24 | Set-DbaAgentAlert | DONE | SetDbaAgentAlertCommand.cs | OK | 100% | 6/6 pass (improved from 1/3 baseline; 2 pre-existing sqlCredential failures now pass) | ShouldProcess, OutputType, Rename/Enable/Disable, Force, InputObject pipeline, null server guard, Rename try/catch added |
-| 25 | Set-DbaAgentJob | PENDING | | | | | ShouldProcess required, depends on Get-DbaAgentJob |
+| 25 | Set-DbaAgentJob | DONE | SetDbaAgentJobCommand.cs | OK | 100% | 1/1 pass | ShouldProcess, OutputType, Force+Category creation, notification level/operator validation, Schedule/ScheduleId attachment, Rename/Enable/Disable/Description/StartStepId/OwnerLogin/DeleteLevel, InputObject pipeline, null server guard |
 | 26 | Set-DbaAgentJobCategory | PENDING | | | | | ShouldProcess required, depends on Get-DbaAgentJobCategory |
 | 27 | Set-DbaAgentJobOutputFile | PENDING | | | | | ShouldProcess required, depends on Get-DbaAgentJobOutputFile |
 | 28 | Set-DbaAgentJobOwner | PENDING | | | | | ShouldProcess required |

project/dbatools.Tests/Commands/SetDbaAgentJobCommandTests.cs

@@ -0,0 +1,113 @@
+using System;
+using System.Management.Automation;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Dataplat.Dbatools.Commands;
+
+namespace Dataplat.Dbatools.Tests.Commands
+{
+    [TestClass]
+    public class SetDbaAgentJobCommandTests
+    {
+        #region ConvertCompletionLevel
+
+        [TestMethod]
+        public void ConvertCompletionLevel_IntValue_ReturnsAsIs()
+        {
+            Assert.AreEqual(0, SetDbaAgentJobCommand.ConvertCompletionLevel(0));
+            Assert.AreEqual(1, SetDbaAgentJobCommand.ConvertCompletionLevel(1));
+            Assert.AreEqual(2, SetDbaAgentJobCommand.ConvertCompletionLevel(2));
+            Assert.AreEqual(3, SetDbaAgentJobCommand.ConvertCompletionLevel(3));
+        }
+
+        [TestMethod]
+        public void ConvertCompletionLevel_StringName_ReturnsCorrectInt()
+        {
+            Assert.AreEqual(0, SetDbaAgentJobCommand.ConvertCompletionLevel("Never"));
+            Assert.AreEqual(1, SetDbaAgentJobCommand.ConvertCompletionLevel("OnSuccess"));
+            Assert.AreEqual(2, SetDbaAgentJobCommand.ConvertCompletionLevel("OnFailure"));
+            Assert.AreEqual(3, SetDbaAgentJobCommand.ConvertCompletionLevel("Always"));
+        }
+
+        [TestMethod]
+        public void ConvertCompletionLevel_NumericString_ReturnsCorrectInt()
+        {
+            Assert.AreEqual(0, SetDbaAgentJobCommand.ConvertCompletionLevel("0"));
+            Assert.AreEqual(1, SetDbaAgentJobCommand.ConvertCompletionLevel("1"));
+            Assert.AreEqual(2, SetDbaAgentJobCommand.ConvertCompletionLevel("2"));
+            Assert.AreEqual(3, SetDbaAgentJobCommand.ConvertCompletionLevel("3"));
+        }
+
+        [TestMethod]
+        public void ConvertCompletionLevel_Null_ReturnsZero()
+        {
+            Assert.AreEqual(0, SetDbaAgentJobCommand.ConvertCompletionLevel(null));
+        }
+
+        [TestMethod]
+        public void ConvertCompletionLevel_UnknownString_ReturnsZero()
+        {
+            Assert.AreEqual(0, SetDbaAgentJobCommand.ConvertCompletionLevel("Invalid"));
+        }
+
+        #endregion ConvertCompletionLevel
+
+        #region GetJobName
+
+        [TestMethod]
+        public void GetJobName_WithNameProperty_ReturnsName()
+        {
+            PSObject obj = new PSObject();
+            obj.Properties.Add(new PSNoteProperty("Name", "TestJob1"));
+            Assert.AreEqual("TestJob1", SetDbaAgentJobCommand.GetJobName(obj));
+        }
+
+        [TestMethod]
+        public void GetJobName_Null_ReturnsNull()
+        {
+            Assert.IsNull(SetDbaAgentJobCommand.GetJobName(null));
+        }
+
+        [TestMethod]
+        public void GetJobName_NoNameProperty_ReturnsNull()
+        {
+            PSObject obj = new PSObject();
+            obj.Properties.Add(new PSNoteProperty("Title", "Something"));
+            Assert.IsNull(SetDbaAgentJobCommand.GetJobName(obj));
+        }
+
+        #endregion GetJobName
+
+        #region GetJobPropertyString
+
+        [TestMethod]
+        public void GetJobPropertyString_ExistingProperty_ReturnsValue()
+        {
+            PSObject obj = new PSObject();
+            obj.Properties.Add(new PSNoteProperty("OperatorToEmail", "DBATeam"));
+            Assert.AreEqual("DBATeam", SetDbaAgentJobCommand.GetJobPropertyString(obj, "OperatorToEmail"));
+        }
+
+        [TestMethod]
+        public void GetJobPropertyString_MissingProperty_ReturnsNull()
+        {
+            PSObject obj = new PSObject();
+            Assert.IsNull(SetDbaAgentJobCommand.GetJobPropertyString(obj, "NonExistent"));
+        }
+
+        [TestMethod]
+        public void GetJobPropertyString_NullObject_ReturnsNull()
+        {
+            Assert.IsNull(SetDbaAgentJobCommand.GetJobPropertyString(null, "Name"));
+        }
+
+        [TestMethod]
+        public void GetJobPropertyString_NullValue_ReturnsNull()
+        {
+            PSObject obj = new PSObject();
+            obj.Properties.Add(new PSNoteProperty("OperatorToEmail", null));
+            Assert.IsNull(SetDbaAgentJobCommand.GetJobPropertyString(obj, "OperatorToEmail"));
+        }
+
+        #endregion GetJobPropertyString
+    }
+}