From a051aabf57ce6ea25672a4ad1119803b23cd21c4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 26 Mar 2026 17:07:45 +0000 Subject: [PATCH 1/5] Initial plan From be15678709c3930f63bc69087bfbe37b98583d14 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 26 Mar 2026 17:08:44 +0000 Subject: [PATCH 2/5] =?UTF-8?q?chore:=20bump=20collection-c-cpp=20patch=20?= =?UTF-8?q?version=201.0.0=20=E2=86=92=201.0.1?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Agent-Logs-Url: https://github.com/devcontainer-community/devcontainer-features/sessions/7cbd8e7f-3d8e-44fd-92fd-2e3fa3ac11f5 Co-authored-by: sebst <592313+sebst@users.noreply.github.com> --- README.md | 2 +- src/collection-c-cpp/devcontainer-feature.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 9bb1428..91e2dfd 100644 --- a/README.md +++ b/README.md @@ -28,7 +28,7 @@ | [clang-tidy](https://github.com/devcontainer-community/devcontainer-features/tree/main/src/clang-tidy) | `clang-tidy` — C++ linter and static analyzer from LLVM | apt | 1.0.0 | | [cloudflare.com/warp-cli](https://github.com/devcontainer-community/devcontainer-features/tree/main/src/cloudflare.com-warp-cli) | `warp-cli` — Cloudflare WARP VPN client | curl | 1.0.1 | | [cmake.org](https://github.com/devcontainer-community/devcontainer-features/tree/main/src/cmake.org) | `cmake` — cross-platform build system generator | apt | 1.0.0 | -| [collection-c-cpp](https://github.com/devcontainer-community/devcontainer-features/tree/main/src/collection-c-cpp) | C/C++ dev collection — cmake, ninja, gdb, valgrind, ccache, cppcheck, clang-format, clang-tidy, distcc, vcpkg, build-essential | meta | 1.0.0 | +| [collection-c-cpp](https://github.com/devcontainer-community/devcontainer-features/tree/main/src/collection-c-cpp) | C/C++ dev collection — cmake, ninja, gdb, valgrind, ccache, cppcheck, clang-format, clang-tidy, distcc, vcpkg, build-essential | meta | 1.0.1 | | [critique.work](https://github.com/devcontainer-community/devcontainer-features/tree/main/src/critique.work) | `critique` — TUI for reviewing git changes | bun | 1.0.0 | | [danmar/cppcheck](https://github.com/devcontainer-community/devcontainer-features/tree/main/src/danmar-cppcheck) | `cppcheck` — static analysis tool for C/C++ code | apt | 1.0.0 | | [delta](https://github.com/devcontainer-community/devcontainer-features/tree/main/src/delta) | `delta` — syntax-highlighting pager for git diffs | gh release | 1.0.1 | diff --git a/src/collection-c-cpp/devcontainer-feature.json b/src/collection-c-cpp/devcontainer-feature.json index 48305ed..412388b 100644 --- a/src/collection-c-cpp/devcontainer-feature.json +++ b/src/collection-c-cpp/devcontainer-feature.json @@ -1,7 +1,7 @@ { "name": "collection-c-cpp", "id": "collection-c-cpp", - "version": "1.0.0", + "version": "1.0.1", "description": "C/C++ dev collection — cmake, ninja, gdb, valgrind, ccache, cppcheck, clang-format, clang-tidy, distcc, vcpkg, build-essential", "documentationURL": "https://github.com/devcontainer-community/devcontainer-features/tree/main/src/collection-c-cpp", "dependsOn": { From c5d06c1afa5d320d28edb8989c934c326fbf5e53 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 26 Mar 2026 17:16:19 +0000 Subject: [PATCH 3/5] fix: add GHCR login to test workflow so dependsOn features resolve Agent-Logs-Url: https://github.com/devcontainer-community/devcontainer-features/sessions/5fc54cdd-742f-4ee9-8b48-a867479e9cb9 Co-authored-by: sebst <592313+sebst@users.noreply.github.com> --- .github/workflows/test.yaml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index f956e74..ed49ad3 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -5,6 +5,7 @@ on: permissions: contents: read + packages: read jobs: get-changed-features: @@ -49,6 +50,13 @@ jobs: steps: - uses: actions/checkout@v4 + - name: "Login to GHCR" + uses: docker/login-action@v3 + with: + registry: ghcr.io + username: ${{ github.actor }} + password: ${{ secrets.GITHUB_TOKEN }} + - name: "Install latest devcontainer CLI" run: npm install -g @devcontainers/cli @@ -67,6 +75,13 @@ jobs: steps: - uses: actions/checkout@v4 + - name: "Login to GHCR" + uses: docker/login-action@v3 + with: + registry: ghcr.io + username: ${{ github.actor }} + password: ${{ secrets.GITHUB_TOKEN }} + - name: "Install latest devcontainer CLI" run: npm install -g @devcontainers/cli @@ -80,6 +95,13 @@ jobs: steps: - uses: actions/checkout@v4 + - name: "Login to GHCR" + uses: docker/login-action@v3 + with: + registry: ghcr.io + username: ${{ github.actor }} + password: ${{ secrets.GITHUB_TOKEN }} + - name: "Install latest devcontainer CLI" run: npm install -g @devcontainers/cli From 0e74e2a86e08a9e32c5fc7ce365e643a5f0f81cf Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 26 Mar 2026 17:22:18 +0000 Subject: [PATCH 4/5] fix: pass GITHUB_TOKEN env to devcontainer test steps for GHCR auth Agent-Logs-Url: https://github.com/devcontainer-community/devcontainer-features/sessions/355b653f-e2ba-422d-b2f7-95586c710fc5 Co-authored-by: sebst <592313+sebst@users.noreply.github.com> --- .github/workflows/test.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index ed49ad3..6648772 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -62,6 +62,8 @@ jobs: - name: "Generating tests for '${{ matrix.features }}' against '${{ matrix.baseImage }}'" run: devcontainer features test --skip-scenarios -f ${{ matrix.features }} -i ${{ matrix.baseImage }} . + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} test-scenarios: needs: get-changed-features @@ -87,6 +89,8 @@ jobs: - name: "Generating tests for '${{ matrix.features }}' scenarios" run: devcontainer features test -f ${{ matrix.features }} --skip-autogenerated --skip-duplicated . + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} test-global: runs-on: ubuntu-latest @@ -107,3 +111,5 @@ jobs: - name: "Testing global scenarios" run: devcontainer features test --global-scenarios-only . + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 47418bf1ea7bd5e8185b9319c21eb588be446ebd Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 26 Mar 2026 17:30:06 +0000 Subject: [PATCH 5/5] fix: correct dependsOn URLs in collection-c-cpp (wrong registry path and tag) Agent-Logs-Url: https://github.com/devcontainer-community/devcontainer-features/sessions/355b653f-e2ba-422d-b2f7-95586c710fc5 Co-authored-by: sebst <592313+sebst@users.noreply.github.com> --- .github/workflows/test.yaml | 28 ------------------- .../devcontainer-feature.json | 22 +++++++-------- 2 files changed, 11 insertions(+), 39 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 6648772..f956e74 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -5,7 +5,6 @@ on: permissions: contents: read - packages: read jobs: get-changed-features: @@ -50,20 +49,11 @@ jobs: steps: - uses: actions/checkout@v4 - - name: "Login to GHCR" - uses: docker/login-action@v3 - with: - registry: ghcr.io - username: ${{ github.actor }} - password: ${{ secrets.GITHUB_TOKEN }} - - name: "Install latest devcontainer CLI" run: npm install -g @devcontainers/cli - name: "Generating tests for '${{ matrix.features }}' against '${{ matrix.baseImage }}'" run: devcontainer features test --skip-scenarios -f ${{ matrix.features }} -i ${{ matrix.baseImage }} . - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} test-scenarios: needs: get-changed-features @@ -77,20 +67,11 @@ jobs: steps: - uses: actions/checkout@v4 - - name: "Login to GHCR" - uses: docker/login-action@v3 - with: - registry: ghcr.io - username: ${{ github.actor }} - password: ${{ secrets.GITHUB_TOKEN }} - - name: "Install latest devcontainer CLI" run: npm install -g @devcontainers/cli - name: "Generating tests for '${{ matrix.features }}' scenarios" run: devcontainer features test -f ${{ matrix.features }} --skip-autogenerated --skip-duplicated . - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} test-global: runs-on: ubuntu-latest @@ -99,17 +80,8 @@ jobs: steps: - uses: actions/checkout@v4 - - name: "Login to GHCR" - uses: docker/login-action@v3 - with: - registry: ghcr.io - username: ${{ github.actor }} - password: ${{ secrets.GITHUB_TOKEN }} - - name: "Install latest devcontainer CLI" run: npm install -g @devcontainers/cli - name: "Testing global scenarios" run: devcontainer features test --global-scenarios-only . - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/src/collection-c-cpp/devcontainer-feature.json b/src/collection-c-cpp/devcontainer-feature.json index 412388b..217a8d5 100644 --- a/src/collection-c-cpp/devcontainer-feature.json +++ b/src/collection-c-cpp/devcontainer-feature.json @@ -5,16 +5,16 @@ "description": "C/C++ dev collection — cmake, ninja, gdb, valgrind, ccache, cppcheck, clang-format, clang-tidy, distcc, vcpkg, build-essential", "documentationURL": "https://github.com/devcontainer-community/devcontainer-features/tree/main/src/collection-c-cpp", "dependsOn": { - "ghcr.io/devcontainer-community/features/cmake.org:1": {}, - "ghcr.io/devcontainer-community/features/ninja-build.org:1": {}, - "ghcr.io/devcontainer-community/features/sourceware.org-gdb:1": {}, - "ghcr.io/devcontainer-community/features/valgrind.org:1": {}, - "ghcr.io/devcontainer-community/features/ccache.dev:1": {}, - "ghcr.io/devcontainer-community/features/danmar-cppcheck:1": {}, - "ghcr.io/devcontainer-community/features/clang-format:1": {}, - "ghcr.io/devcontainer-community/features/clang-tidy:1": {}, - "ghcr.io/devcontainer-community/features/distcc.org:1": {}, - "ghcr.io/devcontainer-community/features/vcpkg.io:1": {}, - "ghcr.io/devcontainer-community/features/apt-build-essential:1": {} + "ghcr.io/devcontainer-community/devcontainer-features/cmake.org:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/ninja-build.org:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/sourceware.org-gdb:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/valgrind.org:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/ccache.dev:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/danmar-cppcheck:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/clang-format:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/clang-tidy:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/distcc.org:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/vcpkg.io:latest": {}, + "ghcr.io/devcontainer-community/devcontainer-features/apt-build-essential:latest": {} } }