Skip to content

Commit 8f87fe3

Browse files
committed
fix: comment out retain and release calls in buffer conversion
1 parent 70a7840 commit 8f87fe3

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

webrtc/src/main/java/dev/onvoid/webrtc/media/video/NativeI420Buffer.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public int getHeight() {
9494

9595
@Override
9696
public I420Buffer toI420() {
97-
retain();
97+
// retain();
9898

9999
return this;
100100
}
@@ -159,13 +159,13 @@ private static VideoFrameBuffer cropAndScale(final I420Buffer buffer, int cropX,
159159
dataU.position(cropX / 2 + cropY / 2 * buffer.getStrideU());
160160
dataV.position(cropX / 2 + cropY / 2 * buffer.getStrideV());
161161

162-
buffer.retain();
162+
// buffer.retain();
163163

164164
return wrap(scaleWidth, scaleHeight, dataY.slice(), buffer.getStrideY(), dataU.slice(),
165165
buffer.getStrideU(), dataV.slice(), buffer.getStrideV());
166166
}
167167

168-
buffer.retain();
168+
// buffer.retain();
169169

170170
I420Buffer newBuffer = allocate(scaleWidth, scaleHeight);
171171

@@ -174,7 +174,7 @@ private static VideoFrameBuffer cropAndScale(final I420Buffer buffer, int cropX,
174174
newBuffer.getDataY(), newBuffer.getStrideY(), newBuffer.getDataU(), newBuffer.getStrideU(),
175175
newBuffer.getDataV(), newBuffer.getStrideV(), scaleWidth, scaleHeight);
176176

177-
buffer.release();
177+
// buffer.release();
178178

179179
return newBuffer;
180180
}

webrtc/src/main/java/dev/onvoid/webrtc/media/video/VideoBufferConverter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public static void convertFromI420(VideoFrameBuffer src, byte[] dst, FourCC four
4040
i420.getWidth(), i420.getHeight(),
4141
fourCC.value());
4242

43-
i420.release();
43+
// i420.release();
4444
}
4545

4646
public static void convertFromI420(VideoFrameBuffer src, ByteBuffer dst, FourCC fourCC) throws Exception {
@@ -82,7 +82,7 @@ public static void convertFromI420(VideoFrameBuffer src, ByteBuffer dst, FourCC
8282
fourCC.value());
8383
}
8484

85-
i420.release();
85+
// i420.release();
8686
}
8787

8888
private native static void I420toByteArray(

0 commit comments

Comments
 (0)