Skip to content

Added a few methods, fixed POST methods#72

Open
peterjaap wants to merge 1 commit into
dg:masterfrom
peterjaap:patch-1
Open

Added a few methods, fixed POST methods#72
peterjaap wants to merge 1 commit into
dg:masterfrom
peterjaap:patch-1

Conversation

@peterjaap

Copy link
Copy Markdown

Some POST methods need the data in the URL query parameters, like the GET methods

Some POST methods need the data in the URL query parameters, like the GET methods
@jgsaez9

jgsaez9 commented May 18, 2020

Copy link
Copy Markdown

Images and text cannot be published. It does not work

$imagePath = "images/img01.jpg";
$tweet = $twitter->send('one', array($imagePath));

It does not show any error. But only publish text

@peterjaap

Copy link
Copy Markdown
Author

@joska1993 is this problem occurring with the specific change in this PR?

@cleverimmo

cleverimmo commented Jun 13, 2020

Copy link
Copy Markdown

I got the same problem with images. Text messages are sent, images not. I checked the media_id which is created correctly, however the result object after the tweet->send does not contain any media_url.

Sorry, I guess it was the wrong place to post the message. It was my first on github :-)

@avramovic

avramovic commented Sep 16, 2021

Copy link
Copy Markdown

This PR actually fixes the "no images" problem when tweeting. It would be nice if it was merged, as right now I'm editing files in my vendor folder in order to make it work

edit: I placed your repo URL as a repository and pointed it in composer.json to use your patch version:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:peterjaap/twitter-php.git"
        }
    ],
    "require": {
        "dg/twitter-php": "dev-patch-1"
    }
}

Ran composer update and voila - I'm using your patched version :)

@peterjaap

peterjaap commented Sep 17, 2021

Copy link
Copy Markdown
Author

@avramovic for a temporary solution like that, a better approach would be to add .patch to the URL of this page (so https://github.com/dg/twitter-php/pull/72.patch- it will redirect you) and use that patch URL with vaimo/composer-patches to patch it automatically after composer install.

@avramovic

Copy link
Copy Markdown

@peterjaap That looks interesting. Thank you, I'll check it out.

@peterjaap

Copy link
Copy Markdown
Author

@dg can you merge this? Still open..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants