CLI: product file show/delete queries/returns productID in decimal format

[peterfriedl]

When querying product files via the CLI, productID is queried (?!) or at least returned in decimal format:

prosEO (S5P)> product file show 886821
(E6206) Product with database ID 886,821 has no files

prosEO (S5P)> product file delete 886821 inpuls
(E6218) No product file found for product database ID 886,821 and processing facility inpuls

Question: Does the query really execute a request for the ID 886,821 (instead of 886821) and therefore return no files? Or is it just an issue of the error message formatting?

[emelchinger]

This is just formatting of the message.

[emelchinger]

An existing product file would be shown, e.g.

prosEO (PTM)> product file show 99863
Processing Facility            Product File Name
localhost                      PTM_TEST_PTM_L1B_P1_20191104T090000_20191104T090001_03000_2_0.1.0_20240123T055957.nc

[katharinabassler]

Is that actually a fix, though? The CLI is written in English, so applying English decimal separators (.) and thousands separator (,) is consistent. Leaving separator out just reduces readability. I propose to undo this change.

[tangobravo62]

The change was requested by the user, and displaying database IDs without any separators is in line with (at least) the practice in the prosEO GUI. Therefore the change is OK and shall be applied. I just wonder whether it should be extended to all other CLI classes, which also rely on standard formatting for logging (or perhaps we can suppress formatting of longs generally in the Logging module).