Implement reversible span selection behavior#526
Open
hitex wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @domferr
First of all, thank you for amazing extension!
My PR implements a feature that I am missing from FancyZones - reversible span selections. Currently when spanning the window, if you move too much with the mouse - you need to cancel spanning and start over, which is really annoying. In this PR you can change the spanning area freely.
Heres how the logic is implemented:
Here is the video recording of the behavior:
reversible-span.mp4
It works on Gnome 49. Did not test older versions yet because I want to get your feedback first and see if you are willing to incorporate this change. Let me know what you think.
PS. I really missed the tests, did you consider adding them at some point?