Merge pull request erikdarlingdata#627 from erikdarlingdata/dev

Release v2.3.0

Author: erikdarlingdata

.coderabbit.yaml

@@ -0,0 +1,67 @@
+# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
+
+language: "en-US"
+early_access: false
+enable_free_tier: true
+
+reviews:
+  profile: "chill"
+  high_level_summary: true
+  review_status: true
+  commit_status: true
+  collapse_walkthrough: true
+  sequence_diagrams: false
+  poem: false
+
+  path_filters:
+    - "!**/*.Designer.cs"
+    - "!**/bin/**"
+    - "!**/obj/**"
+    - "!**/publish/**"
+    - "!**/*.user"
+    - "!**/*.suo"
+
+  path_instructions:
+    - path: "Dashboard/**/*.cs"
+      instructions: >
+        This is a WPF .NET 8 desktop app (Dashboard) that reads from SQL Server.
+        Uses data binding, async/await patterns, and INotifyPropertyChanged.
+        Watch for: null reference risks, disposal of SQL connections,
+        thread safety with UI dispatch, and proper async patterns.
+    - path: "Lite/**/*.cs"
+      instructions: >
+        This is a WPF .NET 8 desktop app (Lite) that collects SQL Server DMV data
+        into a local DuckDB database. Uses ReaderWriterLockSlim for DB coordination.
+        Watch for: connection disposal, thread safety, DuckDB access patterns,
+        and proper async/await usage.
+    - path: "**/*.sql"
+      instructions: >
+        T-SQL stored procedures and scripts for SQL Server.
+        Watch for: SQL injection risks, missing error handling (TRY/CATCH),
+        proper use of SET NOCOUNT ON, and parameter sniffing concerns.
+    - path: "Installers/**"
+      instructions: >
+        WiX-based MSI installer projects. Be cautious about upgrade paths
+        and file versioning. Schema upgrades go in upgrades/ folder, not install scripts.
+
+  auto_review:
+    enabled: true
+    drafts: false
+    base_branches:
+      - "dev"
+      - "main"
+
+  tools:
+    gitleaks:
+      enabled: true
+    github-checks:
+      enabled: true
+
+chat:
+  auto_reply: true
+
+knowledge_base:
+  learnings:
+    scope: "local"
+  pull_requests:
+    scope: "local"

CHANGELOG.md

@@ -5,6 +5,87 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.3.0] - 2026-03-18
+
+### Important
+
+- **Schema upgrade**: Six columns widened across three tables (`query_stats`, `cpu_scheduler_stats`, `waiting_tasks`, `database_size_stats`) to match DMV documentation types. These are in-place ALTER COLUMN operations — fast on any table size, no data migration. Upgrade scripts run automatically via the CLI/GUI installer.
+- **SQL Server version check**: Both installers now reject SQL Server 2014 and earlier before running any scripts, with a clear error message. Azure MI (EngineEdition 8) is always accepted. ([#543])
+- **Installer adversarial tests**: 35 automated tests covering upgrade failures, data survival, idempotency, version detection fallback, file filtering, restricted permissions, and more. These run as part of pre-release validation. ([#543])
+
+### Added
+
+- **ErikAI analysis engine** — rule-based inference engine for Lite that scores server health across wait stats, CPU, memory, I/O, blocking, tempdb, and query performance. Surfaces actionable findings with severity, detail, and recommended actions. Includes anomaly detection (baseline comparison for acute deviations), bad actor detection (per-query scoring for consistently terrible queries), and CPU spike detection for bursty workloads. ([#589], [#593])
+- **ErikAI Dashboard port** — full analysis engine ported to Dashboard with SQL Server backend ([#590])
+- **FinOps cost optimization recommendations** — Phase 1-4 checks: enterprise feature audit, CPU/memory right-sizing, compression savings estimator, unused index cost quantification, dormant database detection, dev/test workload detection, VM right-sizing, storage tier optimization, reserved capacity candidates ([#564])
+- **FinOps High Impact Queries** — 80/20 analysis showing which queries consume the most resources across all dimensions ([#564])
+- **FinOps dollar-denominated cost attribution** — per-server monthly cost setting with proportional database-level breakdown ([#564])
+- **On-demand plan fetch** for bad actor and analysis findings — click to retrieve execution plans for flagged queries ([#604])
+- **Plan analysis integration** — findings include execution plan analysis when plans are available ([#594])
+- **Server unreachable email alerts** — Dashboard sends email (not just tray notification) when a monitored server goes offline or comes back online ([#529])
+- **Column filters on all FinOps DataGrids** — filter funnel icons on every column header across all 7 FinOps grids in Lite and Dashboard ([#562])
+- **Column filters on Dashboard** IdleDatabases, TempDB, and Index Analysis grids
+- **Lite data import** — "Import Data" button brings in monitoring history from a previous Lite install via parquet files, preserving trend data across version upgrades ([#566])
+- **Per-server Utility Database setting** — Lite can call community stored procedures (sp_IndexCleanup) from a database other than master ([#555])
+- **SQL Server version check** in both CLI and GUI installers — rejects 2014 and earlier with a clear message ([#543])
+- **Execution plan analysis MCP tools** for both Dashboard and Lite
+- **Full MCP tool coverage** — Dashboard expanded from 28 to 57 tools, Lite from 32 to 51 tools ([#576], [#577])
+- **Self-sufficient analyze_server drill-down** — MCP tool returns complete analysis, not breadcrumb trail ([#578])
+- **NuGet package dependency licenses** in THIRD_PARTY_NOTICES.md
+
+### Changed
+
+- **Azure SQL DB FinOps** — all collectors (database sizes, query stats, file I/O) now connect to each database individually instead of only querying master. Server Inventory uses dynamic SQL to avoid `sys.master_files` dependency. ([#557])
+- **Index Analysis scroll fix** — both summary and detail grids now use proportional heights instead of Auto, so they scroll independently with large result sets ([#554])
+- **Dashboard Add Server dialog** — increased MaxHeight from 700 to 850px so buttons are visible when SQL auth fields are shown
+- **GUI installer** — Uninstall button now correctly enables after a successful install
+- **GUI installer** — fixed encryption mapping and history logging ([#612])
+- **Dashboard visible sub-tab only refresh** on auto-refresh ticks ([#528])
+- Analysis engine decouples data maturity check from analysis window
+
+### Fixed
+
+- **Installer dropping database on every upgrade** — `00_uninstall.sql` excluded from install file list, installer aborts on upgrade failure, version detection fallback returns "1.0.0" instead of null ([#538], [#539])
+- **SQL dumps on mirroring passive servers** from FinOps collectors ([#535])
+- **RetrievedFromCache** always showing False ([#536])
+- **Arithmetic overflow** in query_stats collector for dop/thread columns ([#547])
+- **Lite perfmon chart bugs** and Dashboard ScottPlot crash handling ([#544], [#545])
+- **PLE=0 scoring bug** — was scored as harmless, now correctly flagged ([#543])
+- **PercentRank >1.0** bug in HealthCalculator
+- **6 verified Lite bugs** from code review ([#611])
+- **Enterprise feature audit text** — partitioning is not Enterprise-only
+- **FinOps collector scheduling**, server switch, and utilization bugs
+- **Dashboard drill-down** Unicode arrow in story path split
+- **Empty DataGrid scrollbar artifacts** — hide grids when empty across all FinOps tabs
+- **Query preview** — truncated in row, full text in tooltip
+
+[#529]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/529
+[#535]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/535
+[#536]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/536
+[#538]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/538
+[#539]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/539
+[#543]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/543
+[#544]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/544
+[#545]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/545
+[#547]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/547
+[#554]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/554
+[#555]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/555
+[#557]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/557
+[#562]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/562
+[#564]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/564
+[#566]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/566
+[#576]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/576
+[#577]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/577
+[#578]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/578
+[#528]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/528
+[#589]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/589
+[#590]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/590
+[#593]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/593
+[#594]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/594
+[#604]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/604
+[#611]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/611
+[#612]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/612
+
 ## [2.2.0] - 2026-03-11
 
 **Contributors:** [@HannahVernon](https://github.com/HannahVernon), [@ClaudioESSilva](https://github.com/ClaudioESSilva), [@dphugo](https://github.com/dphugo), [@Orestes](https://github.com/Orestes) — thank you!

Dashboard/AddServerDialog.xaml

@@ -2,7 +2,7 @@
         xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
         xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
         Title="Add SQL Server"
-        SizeToContent="Height" Width="450" MaxHeight="700"
+        SizeToContent="Height" Width="450" MaxHeight="850"
         WindowStartupLocation="CenterOwner"
         ResizeMode="NoResize"
         Background="{DynamicResource BackgroundBrush}"
@@ -100,6 +100,14 @@
                 <CheckBox x:Name="IsFavoriteCheckBox" Content="Mark as favorite (appears at top of list)"
                           Foreground="{DynamicResource ForegroundBrush}" Margin="0,0,0,6"/>
 
+                <!-- Monthly Cost -->
+                <StackPanel Orientation="Horizontal" Margin="0,0,0,6">
+                    <TextBlock Text="Monthly Cost ($):" Width="110" VerticalAlignment="Center"
+                               Foreground="{DynamicResource ForegroundBrush}"/>
+                    <TextBox x:Name="MonthlyCostTextBox" Width="100" TextAlignment="Right" Text="0"
+                             ToolTip="What this server costs per month (license, compute, storage combined). Used for FinOps cost attribution. Leave 0 to hide cost columns."/>
+                </StackPanel>
+
                 <!-- Description -->
                 <TextBlock Text="Description (optional):" Margin="0,4,0,4"
                            Foreground="{DynamicResource ForegroundBrush}"/>

Dashboard/AddServerDialog.xaml.cs

@@ -42,6 +42,7 @@ public AddServerDialog(ServerConnection existingServer)
             ServerNameTextBox.Text = existingServer.ServerName;
             DescriptionTextBox.Text = existingServer.Description;
             IsFavoriteCheckBox.IsChecked = existingServer.IsFavorite;
+            MonthlyCostTextBox.Text = existingServer.MonthlyCostUsd.ToString(System.Globalization.CultureInfo.InvariantCulture);
 
             // Load encryption settings
             EncryptModeComboBox.SelectedIndex = existingServer.EncryptMode switch
@@ -328,9 +329,15 @@ private async void Save_Click(object sender, RoutedEventArgs e)
                 ServerConnection.IsFavorite = IsFavoriteCheckBox.IsChecked == true;
                 ServerConnection.EncryptMode = GetSelectedEncryptMode();
                 ServerConnection.TrustServerCertificate = TrustServerCertificateCheckBox.IsChecked == true;
+                if (decimal.TryParse(MonthlyCostTextBox.Text, System.Globalization.NumberStyles.Any, System.Globalization.CultureInfo.InvariantCulture, out var editCost) && editCost >= 0)
+                    ServerConnection.MonthlyCostUsd = editCost;
             }
             else
             {
+                decimal monthlyCost = 0m;
+                if (decimal.TryParse(MonthlyCostTextBox.Text, System.Globalization.NumberStyles.Any, System.Globalization.CultureInfo.InvariantCulture, out var newCost) && newCost >= 0)
+                    monthlyCost = newCost;
+
                 ServerConnection = new ServerConnection
                 {
                     DisplayName = displayName,
@@ -341,7 +348,8 @@ private async void Save_Click(object sender, RoutedEventArgs e)
                     CreatedDate = DateTime.Now,
                     LastConnected = DateTime.Now,
                     EncryptMode = GetSelectedEncryptMode(),
-                    TrustServerCertificate = TrustServerCertificateCheckBox.IsChecked == true
+                    TrustServerCertificate = TrustServerCertificateCheckBox.IsChecked == true,
+                    MonthlyCostUsd = monthlyCost
                 };
             }
 

Dashboard/Analysis/AnalysisModels.cs

@@ -0,0 +1,152 @@
+using System;
+using System.Collections.Generic;
+
+namespace PerformanceMonitorDashboard.Analysis;
+
+/// <summary>
+/// A scored observation from collected data.
+/// </summary>
+public class Fact
+{
+    public string Source { get; set; } = string.Empty;
+    public string Key { get; set; } = string.Empty;
+    public double Value { get; set; }
+    public double BaseSeverity { get; set; }
+    public double Severity { get; set; }
+    public int ServerId { get; set; }
+    public string? DatabaseName { get; set; }
+
+    /// <summary>
+    /// Raw metric values for analysis and audit trail.
+    /// Keys are metric-specific (e.g., "wait_time_ms", "waiting_tasks_count").
+    /// </summary>
+    public Dictionary<string, double> Metadata { get; set; } = [];
+
+    /// <summary>
+    /// Amplifiers that were evaluated for this fact.
+    /// </summary>
+    public List<AmplifierResult> AmplifierResults { get; set; } = [];
+}
+
+/// <summary>
+/// Result of evaluating a single amplifier against the fact set.
+/// </summary>
+public class AmplifierResult
+{
+    public string Description { get; set; } = string.Empty;
+    public bool Matched { get; set; }
+    public double Boost { get; set; }
+}
+
+/// <summary>
+/// A conditional edge in the relationship graph.
+/// </summary>
+public class Edge
+{
+    public string Source { get; set; } = string.Empty;
+    public string Destination { get; set; } = string.Empty;
+    public string Category { get; set; } = string.Empty;
+    public string PredicateDescription { get; set; } = string.Empty;
+
+    /// <summary>
+    /// Evaluates whether this edge should be followed given the current fact set.
+    /// </summary>
+    public Func<IReadOnlyDictionary<string, Fact>, bool> Predicate { get; set; } = _ => false;
+}
+
+/// <summary>
+/// A complete analysis story — the path from root symptom to leaf recommendation.
+/// </summary>
+public class AnalysisStory
+{
+    public string RootFactKey { get; set; } = string.Empty;
+    public double RootFactValue { get; set; }
+    public double Severity { get; set; }
+    public double Confidence { get; set; }
+    public string Category { get; set; } = string.Empty;
+    public List<string> Path { get; set; } = [];
+    public string StoryPath { get; set; } = string.Empty;
+    public string StoryPathHash { get; set; } = string.Empty;
+    public string StoryText { get; set; } = string.Empty;
+    public string? LeafFactKey { get; set; }
+    public double? LeafFactValue { get; set; }
+    public int FactCount { get; set; }
+    public bool IsAbsolution { get; set; }
+}
+
+/// <summary>
+/// A persisted finding from a previous analysis run.
+/// Maps to the analysis_findings DuckDB table.
+/// </summary>
+public class AnalysisFinding
+{
+    public long FindingId { get; set; }
+    public DateTime AnalysisTime { get; set; }
+    public int ServerId { get; set; }
+    public string ServerName { get; set; } = string.Empty;
+    public string? DatabaseName { get; set; }
+    public DateTime? TimeRangeStart { get; set; }
+    public DateTime? TimeRangeEnd { get; set; }
+    public double Severity { get; set; }
+    public double Confidence { get; set; }
+    public string Category { get; set; } = string.Empty;
+    public string StoryPath { get; set; } = string.Empty;
+    public string StoryPathHash { get; set; } = string.Empty;
+    public string StoryText { get; set; } = string.Empty;
+    public string RootFactKey { get; set; } = string.Empty;
+    public double? RootFactValue { get; set; }
+    public string? LeafFactKey { get; set; }
+    public double? LeafFactValue { get; set; }
+    public int FactCount { get; set; }
+
+    /// <summary>
+    /// Drill-down data collected after graph traversal. Ephemeral — not persisted to DuckDB.
+    /// Contains supporting detail keyed by category (e.g., "top_deadlocks", "queries_at_spike").
+    /// </summary>
+    public Dictionary<string, object>? DrillDown { get; set; }
+}
+
+/// <summary>
+/// A muted finding pattern. Maps to the analysis_muted DuckDB table.
+/// </summary>
+public class AnalysisMuted
+{
+    public long MuteId { get; set; }
+    public int? ServerId { get; set; }
+    public string? DatabaseName { get; set; }
+    public string StoryPathHash { get; set; } = string.Empty;
+    public string StoryPath { get; set; } = string.Empty;
+    public DateTime MutedDate { get; set; }
+    public string? Reason { get; set; }
+}
+
+/// <summary>
+/// A user-configured exclusion filter. Maps to the analysis_exclusions DuckDB table.
+/// </summary>
+public class AnalysisExclusion
+{
+    public long ExclusionId { get; set; }
+    public string ExclusionType { get; set; } = string.Empty;
+    public string ExclusionValue { get; set; } = string.Empty;
+    public int? ServerId { get; set; }
+    public string? DatabaseName { get; set; }
+    public bool IsEnabled { get; set; } = true;
+    public DateTime CreatedDate { get; set; }
+    public string? Description { get; set; }
+}
+
+/// <summary>
+/// A severity threshold value. Maps to the analysis_thresholds DuckDB table.
+/// </summary>
+public class AnalysisThreshold
+{
+    public long ThresholdId { get; set; }
+    public string Category { get; set; } = string.Empty;
+    public string FactKey { get; set; } = string.Empty;
+    public string ThresholdType { get; set; } = string.Empty;
+    public double ThresholdValue { get; set; }
+    public int? ServerId { get; set; }
+    public string? DatabaseName { get; set; }
+    public bool IsEnabled { get; set; } = true;
+    public DateTime ModifiedDate { get; set; }
+}