Skip to content

Commit 542ccb5

Browse files
committed
fix: review feedback
1 parent 9715b35 commit 542ccb5

3 files changed

Lines changed: 9 additions & 12 deletions

File tree

docs/internals/requirements/requirements.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1180,8 +1180,6 @@ Testing
11801180
* Component Security Analysis (Threat Scenario) -> ``comp_sec_ana``
11811181
* Platform Security Analysis (Threat Scenario) -> ``plat_sec_ana``
11821182

1183-
All need types have a mandatory ``title`` and unique ``id``.
1184-
11851183

11861184
.. tool_req:: Security Analysis: STRIDE Threat ID Attribute
11871185
:id: tool_req__docs_sec_attr_stride_threat_id

src/extensions/score_metamodel/__init__.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,15 @@ def setup(app: Sphinx) -> dict[str, str | bool]:
327327
app.config.needs_types += metamodel.needs_types
328328
app.config.needs_links.update(metamodel.needs_links)
329329
app.config.needs_fields.update(metamodel.needs_fields)
330+
app.config.needs_string_links.setdefault(
331+
"mitigation_issue_linker",
332+
{
333+
"regex": r"(?P<url>https://github\.com/[^/]+/(?P<repo>[^/]+)/issues/(?P<number>\d+))",
334+
"link_url": "{{url}}",
335+
"link_name": "{{repo}}#{{number}}",
336+
"options": ["mitigation_issue"],
337+
},
338+
)
330339
app.config.graph_checks = metamodel.needs_graph_check
331340
app.config.prohibited_words_checks = metamodel.prohibited_words_checks
332341

src/extensions/score_source_code_linker/__init__.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -151,16 +151,6 @@ def setup_source_code_linker(app: Sphinx, ws_root: Path | None):
151151
"options": ["source_code_link", "testlink"],
152152
},
153153
)
154-
app.config.needs_string_links.setdefault(
155-
"mitigation_issue_linker",
156-
{
157-
"regex": r"(?P<url>https://github\.com/[^/]+/(?P<repo>[^/]+)/issues/(?P<number>\d+))",
158-
"link_url": "{{url}}",
159-
"link_name": "{{repo}}#{{number}}",
160-
"options": ["mitigation_issue"],
161-
},
162-
)
163-
164154
score_sourcelinks_json = os.environ.get("SCORE_SOURCELINKS")
165155
if not score_sourcelinks_json:
166156
score_sourcelinks_json = str(

0 commit comments

Comments
 (0)