From 0f77b65ec3da92779f840a342406b5aa9b593fc7 Mon Sep 17 00:00:00 2001 From: Jeremy Wootten Date: Mon, 17 Aug 2026 17:34:10 +0100 Subject: [PATCH 1/4] Use toggled signal --- src/Widgets/ChooseProjectButton.vala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Widgets/ChooseProjectButton.vala b/src/Widgets/ChooseProjectButton.vala index 132e2c74d4..1681f1c972 100644 --- a/src/Widgets/ChooseProjectButton.vala +++ b/src/Widgets/ChooseProjectButton.vala @@ -124,7 +124,7 @@ public class Code.ChooseProjectButton : Gtk.Bin { } }); - menu_button.activate.connect (() => { + menu_button.toggled.connect (() => { if (menu_button.active) { unowned var active_path = Scratch.Services.GitManager.get_instance ().active_project_path; foreach (var child in project_listbox.get_children ()) { From 2572211d87cda327b3694d3bfb2b8b978ed34bd4 Mon Sep 17 00:00:00 2001 From: Jeremy Wootten Date: Mon, 17 Aug 2026 17:35:00 +0100 Subject: [PATCH 2/4] Change property name to "is-active-project" --- src/Widgets/ChooseProjectButton.vala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Widgets/ChooseProjectButton.vala b/src/Widgets/ChooseProjectButton.vala index 1681f1c972..ff6fb175ab 100644 --- a/src/Widgets/ChooseProjectButton.vala +++ b/src/Widgets/ChooseProjectButton.vala @@ -130,7 +130,7 @@ public class Code.ChooseProjectButton : Gtk.Bin { foreach (var child in project_listbox.get_children ()) { var project_row = ((ProjectRow) child); // All paths must not end in directory separator so can be compared directly - project_row.active = active_path == project_row.project_path; + project_row.is_active_project = active_path == project_row.project_path; } } }); @@ -161,7 +161,7 @@ public class Code.ChooseProjectButton : Gtk.Bin { public class ProjectRow : Gtk.ListBoxRow { private Gtk.CheckButton check_button; - public bool active { + public bool is_active_project { get { return check_button.active; } From 1ace273b2b2656a62cb943c5fc2ef7fd54d28db4 Mon Sep 17 00:00:00 2001 From: Jeremy Wootten Date: Mon, 17 Aug 2026 17:42:46 +0100 Subject: [PATCH 3/4] Fix css warning --- data/Application.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/Application.css b/data/Application.css index b65b64ad25..6b743ee581 100644 --- a/data/Application.css +++ b/data/Application.css @@ -45,7 +45,7 @@ textview.scrubber { background-color: transparent; } -.fuzzy-item:focused, +.fuzzy-item:focus, .fuzzy-item:hover { border-radius: 0.5rem; } @@ -54,7 +54,7 @@ textview.scrubber { background-color: @theme_unfocused_selected_bg_color; } -.fuzzy-item:focused { +.fuzzy-item:focus { background-color: @selected_bg_color; color: @selected_fg_color; } From 4a79c6e93e6377d5c0f32bac1a529406af808bbb Mon Sep 17 00:00:00 2001 From: Jeremy Wootten Date: Mon, 17 Aug 2026 17:46:51 +0100 Subject: [PATCH 4/4] Do not use return_if_fail where commonly fails --- src/Services/Document.vala | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Services/Document.vala b/src/Services/Document.vala index 60bd7fc563..b784b0d439 100644 --- a/src/Services/Document.vala +++ b/src/Services/Document.vala @@ -286,7 +286,10 @@ namespace Scratch.Services { this.source_view.buffer.create_tag ("highlight_search_all", "background", "yellow", null); this.source_view.notify["is-focus"].connect (() => { - return_if_fail (!locked); + if (locked) { + return; + } + if (source_view.is_focus) { if (!is_file_temporary) { check_undoable_actions ();