chore: switch kysely to workspace catalog#1144
Merged
Merged
Conversation
Adds kysely to the pnpm-workspace.yaml catalog and points the direct references in core, auth-atproto, and sandbox-workerd at it. Also bumps sandbox-workerd's kysely peer range from >=0.27.0 to >=0.29.0 to match the version the rest of the monorepo has been on since the kysely 0.29 upgrade.
🦋 Changeset detectedLatest commit: 9f4e73c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-i18n | 9f4e73c | May 22 2026, 01:06 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-perf-coordinator | 9f4e73c | May 22 2026, 01:06 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 9f4e73c | May 22 2026, 01:07 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | 9f4e73c | May 22 2026, 01:07 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | 9f4e73c | May 22 2026, 01:08 PM |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the monorepo’s kysely versioning by adding it to the pnpm-workspace.yaml catalog and switching selected packages to use catalog: so pnpm won’t install multiple Kysely versions side-by-side.
Changes:
- Added
kysely: ^0.29.0to the workspace catalog. - Switched
emdash,@emdash-cms/auth-atproto, and@emdash-cms/sandbox-workerdto usekysely: "catalog:"where appropriate. - Updated
@emdash-cms/sandbox-workerd’skyselypeer dependency minimum to>=0.29.0and regeneratedpnpm-lock.yaml.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds kysely to the shared catalog for consistent versioning. |
| pnpm-lock.yaml | Reflects catalog entry + updated specifiers/versions for affected importers. |
| packages/workerd/package.json | Aligns kysely peer range and uses catalog for dev dependency. |
| packages/core/package.json | Switches emdash’s kysely dependency to catalog:. |
| packages/auth-atproto/package.json | Switches kysely dependency to catalog:. |
| .changeset/workerd-kysely-catalog.md | Records the dependency alignment change for release notes. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@atcute/oauth-node-client": "^1.1.0", | ||
| "@emdash-cms/auth": "workspace:*", | ||
| "kysely": "^0.29.0" | ||
| "kysely": "catalog:" |
| "@emdash-cms/sandbox-workerd": patch | ||
| --- | ||
|
|
||
| Aligns the `kysely` peer dependency with the rest of the monorepo (`>=0.29.0`) and switches the dev/peer references to the workspace catalog so all packages bump in lockstep going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The new
packages/workerd(@emdash-cms/sandbox-workerd, added in #426) declaredkyselyat^0.27.0, while the rest of the monorepo has been on^0.29.0for a while. That meantpnpm installwas happy to resolve two different kysely versions side by side.This PR:
kysely: ^0.29.0to thepnpm-workspace.yamlcatalog.kyselyreferences inemdash,@emdash-cms/auth-atproto, and@emdash-cms/sandbox-workerdtocatalog:.sandbox-workerd'skyselypeer range from>=0.27.0to>=0.29.0so it reflects the version actually exercised in CI.@emdash-cms/authand@emdash-cms/cloudflarealone — peers stay as explicit ranges.pnpm-lock.yaml.Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output
None — package metadata + lockfile only.