Skip to content

Commit d984d06

Browse files
authored
Fix/remove TODO in is_lock_free tests. NFC (#26649)
Returning true here is apparently the correct behavior. See https://issues.chromium.org/issues/40742723
1 parent 317c35d commit d984d06

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

test/pthread/is_lock_free.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ void test() {
1515
assert(emscripten_atomics_is_lock_free(1));
1616
assert(emscripten_atomics_is_lock_free(2));
1717
assert(emscripten_atomics_is_lock_free(4));
18-
// Chrome is buggy, see
19-
// https://bugs.chromium.org/p/chromium/issues/detail?id=1167449
20-
//assert(emscripten_atomics_is_lock_free(8));
18+
assert(emscripten_atomics_is_lock_free(8));
2119
assert(!emscripten_atomics_is_lock_free(16));
2220
assert(!emscripten_atomics_is_lock_free(31));
2321

test/wasm_worker/hardware_concurrency_is_lock_free.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ void test() {
1111
assert(emscripten_atomics_is_lock_free(1));
1212
assert(emscripten_atomics_is_lock_free(2));
1313
assert(emscripten_atomics_is_lock_free(4));
14-
// Chrome is buggy, see
15-
// https://bugs.chromium.org/p/chromium/issues/detail?id=1167449
16-
//assert(emscripten_atomics_is_lock_free(8));
14+
assert(emscripten_atomics_is_lock_free(8));
1715
assert(!emscripten_atomics_is_lock_free(16));
1816
assert(!emscripten_atomics_is_lock_free(31));
1917

0 commit comments

Comments
 (0)