From e7e67e257ddc1f55833ea1b64dd6c7e4903cd42e Mon Sep 17 00:00:00 2001 From: John McLear Date: Sun, 21 Jun 2026 12:51:54 +0100 Subject: [PATCH] ci: stop pinning pnpm to v10; read etherpad's packageManager pin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The CI forced pnpm down to 10.x via `version: 10` in pnpm/action-setup, while Etherpad core requires `pnpm@11.1.2` (its packageManager field). Under the mismatch the dev server's lazy frontend build never completed, so the `ace_outer` editor iframe never rendered and *every* frontend spec (including core a11y/rtl specs) timed out — the job ran the full 90s-per-test suite with retries until the 6h job limit cancelled it. This has cancelled every frontend run since ~May; PR #89's checkout bump was an unrelated victim, not the cause. Match the rest of the ether/* plugin fleet (e.g. ep_align): read the pnpm version from etherpad's package.json via `package_json_file` (frontend/backend jobs that check core out at ./etherpad-lite) and let the publish job auto-detect from the root core checkout. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/workflows/backend-tests.yml | 2 +- .github/workflows/frontend-tests.yml | 2 +- .github/workflows/npmpublish.yml | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/backend-tests.yml b/.github/workflows/backend-tests.yml index 11fdcdf..ce60319 100644 --- a/.github/workflows/backend-tests.yml +++ b/.github/workflows/backend-tests.yml @@ -33,7 +33,7 @@ jobs: - uses: pnpm/action-setup@v6 name: Install pnpm with: - version: 10 + package_json_file: ./etherpad-lite/package.json run_install: false - name: Get pnpm store directory shell: bash diff --git a/.github/workflows/frontend-tests.yml b/.github/workflows/frontend-tests.yml index 1b3c9c6..5e97e61 100644 --- a/.github/workflows/frontend-tests.yml +++ b/.github/workflows/frontend-tests.yml @@ -23,7 +23,7 @@ jobs: - uses: pnpm/action-setup@v6 name: Install pnpm with: - version: 10 + package_json_file: ./etherpad-lite/package.json run_install: false - name: Get pnpm store directory shell: bash diff --git a/.github/workflows/npmpublish.yml b/.github/workflows/npmpublish.yml index d11591b..f416f77 100644 --- a/.github/workflows/npmpublish.yml +++ b/.github/workflows/npmpublish.yml @@ -34,7 +34,6 @@ jobs: - uses: pnpm/action-setup@v6 name: Install pnpm with: - version: 10 run_install: false - name: Get pnpm store directory shell: bash