Skip to content

Commit c7ecf34

Browse files
haasonsaasclaude
andcommitted
fix: resolve clippy warnings (for_kv_map, unnecessary_map_or)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 889a237 commit c7ecf34

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

src/server/state.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ impl AppState {
189189
"Migrating {} reviews from JSON to PostgreSQL...",
190190
json_reviews.len()
191191
);
192-
for (_id, session) in &json_reviews {
192+
for session in json_reviews.values() {
193193
if let Err(e) = pg.save_review(session).await {
194194
tracing::warn!("Failed to migrate review {}: {}", session.id, e);
195195
}

src/server/storage_json.rs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -132,23 +132,24 @@ impl StorageBackend for JsonStorageBackend {
132132
let source_ok = filters
133133
.source
134134
.as_ref()
135-
.map_or(true, |f| e.diff_source.eq_ignore_ascii_case(f));
135+
.is_none_or(|f| e.diff_source.eq_ignore_ascii_case(f));
136136
let model_ok = filters
137137
.model
138138
.as_ref()
139-
.map_or(true, |f| e.model.eq_ignore_ascii_case(f));
140-
let status_ok = filters.status.as_ref().map_or(true, |f| {
141-
e.event_type.eq_ignore_ascii_case(&format!("review.{}", f))
142-
});
139+
.is_none_or(|f| e.model.eq_ignore_ascii_case(f));
140+
let status_ok = filters
141+
.status
142+
.as_ref()
143+
.is_none_or(|f| e.event_type.eq_ignore_ascii_case(&format!("review.{}", f)));
143144
// Time filters (best-effort for JSON backend using created_at if available)
144145
let time_from_ok = filters
145146
.time_from
146147
.as_ref()
147-
.map_or(true, |from| e.created_at.map_or(true, |t| t >= *from));
148+
.is_none_or(|from| e.created_at.is_none_or(|t| t >= *from));
148149
let time_to_ok = filters
149150
.time_to
150151
.as_ref()
151-
.map_or(true, |to| e.created_at.map_or(true, |t| t <= *to));
152+
.is_none_or(|to| e.created_at.is_none_or(|t| t <= *to));
152153
source_ok && model_ok && status_ok && time_from_ok && time_to_ok
153154
})
154155
.collect();

0 commit comments

Comments
 (0)