Commit 273877b
fix(test): fix printf format repeat and update test coverage (#135)
## Summary
- Fix printf builtin to repeat format string for all arguments (bash
behavior)
- Update date tests to use `grep -q` for format validation
- Add skip markers to unimplemented features across all test categories
- Update implementation status spec with new test counts
## Changes
**Bug Fix:**
- Printf now correctly repeats format string when there are more
arguments than format specifiers (matching bash behavior)
**Test Coverage Improvements:**
| Category | Before | After | Change |
|----------|--------|-------|--------|
| Bash | 330/105 | 406/65 | +76 passing, -40 skipped |
| AWK | 48/41 | 55/34 | +7 passing, -7 skipped |
| Grep | 56/14 | 59/11 | +3 passing, -3 skipped |
| Sed | 49/16 | 50/15 | +1 passing, -1 skipped |
| JQ | 58/37 | 85/10 | +27 passing, -27 skipped |
| **Total** | **541/213** | **655/135** | **+114 passing, -78 skipped**
|
## Test plan
- [x] All spec tests pass (`cargo test --test spec_tests`)
- [x] Full test suite passes (`cargo test --all-features`)
- [x] Clippy and fmt checks pass
https://claude.ai/code/session_01Ga3Nw8bYqS97QNPkw5Pwoa
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 6821bdc commit 273877b
20 files changed
Lines changed: 224 additions & 238 deletions
File tree
- crates/bashkit
- src/builtins
- tests/spec_cases
- awk
- bash
- grep
- jq
- sed
- specs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
25 | 37 | | |
26 | | - | |
27 | 38 | | |
28 | 39 | | |
29 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
| 141 | + | |
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
| 191 | + | |
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
198 | | - | |
| 198 | + | |
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
| 206 | + | |
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
| |||
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
300 | | - | |
| 300 | + | |
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
314 | | - | |
| 314 | + | |
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
| |||
385 | 385 | | |
386 | 386 | | |
387 | 387 | | |
388 | | - | |
| 388 | + | |
389 | 389 | | |
390 | 390 | | |
391 | 391 | | |
| |||
399 | 399 | | |
400 | 400 | | |
401 | 401 | | |
402 | | - | |
403 | 402 | | |
404 | 403 | | |
405 | 404 | | |
406 | 405 | | |
407 | 406 | | |
408 | 407 | | |
409 | | - | |
410 | 408 | | |
411 | 409 | | |
412 | 410 | | |
| |||
427 | 425 | | |
428 | 426 | | |
429 | 427 | | |
430 | | - | |
431 | 428 | | |
432 | 429 | | |
433 | 430 | | |
434 | 431 | | |
435 | 432 | | |
436 | 433 | | |
437 | | - | |
| 434 | + | |
438 | 435 | | |
439 | 436 | | |
440 | 437 | | |
441 | 438 | | |
442 | 439 | | |
443 | 440 | | |
444 | | - | |
| 441 | + | |
445 | 442 | | |
446 | 443 | | |
447 | 444 | | |
448 | 445 | | |
449 | 446 | | |
450 | 447 | | |
451 | | - | |
| 448 | + | |
452 | 449 | | |
453 | 450 | | |
454 | 451 | | |
455 | 452 | | |
456 | 453 | | |
457 | 454 | | |
458 | | - | |
| 455 | + | |
459 | 456 | | |
460 | 457 | | |
461 | 458 | | |
| |||
488 | 485 | | |
489 | 486 | | |
490 | 487 | | |
491 | | - | |
| 488 | + | |
492 | 489 | | |
493 | 490 | | |
494 | 491 | | |
| |||
497 | 494 | | |
498 | 495 | | |
499 | 496 | | |
500 | | - | |
| 497 | + | |
501 | 498 | | |
502 | 499 | | |
503 | 500 | | |
504 | 501 | | |
505 | 502 | | |
506 | 503 | | |
507 | 504 | | |
508 | | - | |
| 505 | + | |
509 | 506 | | |
510 | 507 | | |
511 | 508 | | |
512 | 509 | | |
513 | 510 | | |
514 | 511 | | |
515 | 512 | | |
516 | | - | |
| 513 | + | |
517 | 514 | | |
518 | 515 | | |
519 | 516 | | |
| |||
551 | 548 | | |
552 | 549 | | |
553 | 550 | | |
554 | | - | |
| 551 | + | |
555 | 552 | | |
556 | 553 | | |
557 | 554 | | |
| |||
573 | 570 | | |
574 | 571 | | |
575 | 572 | | |
576 | | - | |
577 | 573 | | |
578 | 574 | | |
579 | 575 | | |
580 | 576 | | |
581 | 577 | | |
582 | 578 | | |
583 | 579 | | |
584 | | - | |
585 | 580 | | |
586 | 581 | | |
587 | 582 | | |
| |||
602 | 597 | | |
603 | 598 | | |
604 | 599 | | |
605 | | - | |
| 600 | + | |
606 | 601 | | |
607 | 602 | | |
608 | 603 | | |
| |||
616 | 611 | | |
617 | 612 | | |
618 | 613 | | |
619 | | - | |
620 | 614 | | |
621 | 615 | | |
622 | 616 | | |
623 | 617 | | |
624 | 618 | | |
625 | 619 | | |
626 | | - | |
627 | 620 | | |
628 | 621 | | |
629 | 622 | | |
| |||
637 | 630 | | |
638 | 631 | | |
639 | 632 | | |
640 | | - | |
| 633 | + | |
641 | 634 | | |
642 | 635 | | |
643 | 636 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
0 commit comments