fix(codex): update review + exec commands for codex v0.130#1653
Open
SpeakShift wants to merge 2 commits into
Open
fix(codex): update review + exec commands for codex v0.130#1653SpeakShift wants to merge 2 commits into
SpeakShift wants to merge 2 commits into
Conversation
codex CLI v0.130 rejects a prompt argument when --base is passed (error: the argument '[PROMPT]' cannot be used with '--base <BRANCH>'), so every '/codex review' invocation fails on the first command. Default review now runs 'codex review --base <base>' with no prompt. Custom-instruction review passes the prompt and omits --base (Codex auto-detects the diff). Also drops the deprecated --enable web_search_cached flag from the review commands (web search is on by default in v0.130). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ands codex v0.130 warns that the web_search_cached feature flag is deprecated (web search is on by default). Remove --enable web_search_cached from the three 'codex exec' commands (Challenge + Consult modes) and refresh the 'Web search' doc paragraph. The review commands were cleaned in the previous commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
SpeakShift
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
/codexskill's command invocations for codex CLI v0.130.Problem
1.
codex reviewrejects a[PROMPT]with--base. In codex v0.130:The skill's Step 2A (Review mode) always passes the filesystem-boundary string as a prompt and
--base <base>together — so every/codex reviewinvocation fails on its first command. Hit live while running/codex reviewon a real PR.2.
--enable web_search_cachedis deprecated. codex v0.130 warns:web_search_cached is deprecated because web search is enabled by default.Fix
codex/SKILL.md.tmpl+ the regeneratedcodex/SKILL.md:codex review --base <base>with no prompt. Codex reviews the diff against the base with its default review instructions./codex review focus on security) → passes the prompt and omits--base— a[PROMPT]and--baseare mutually exclusive, so Codex auto-detects the diff against the default base.--enable web_search_cachedflag from all codex commands — the two review commands and the threecodex execcommands (Challenge + Consult modes) — and refreshes the "Web search" doc paragraph.The filesystem-boundary instruction is necessarily dropped from the default
--basereview path (no prompt slot). That is safe: review mode only inspects the diff, and skill-definition files are not part of a normal repo diff. The custom-instruction path still carries the boundary.Commits
fix(codex): codex review --base cannot take a [PROMPT] argfix(codex): drop deprecated --enable web_search_cached from exec commandsScope
Both Review and Exec (Challenge / Consult) modes are covered. No behavior change beyond codex v0.130 compatibility.
🤖 Generated with Claude Code