Skip to content

fix: guard question log payload args#1665

Open
hiSandog wants to merge 1 commit into
garrytan:mainfrom
hiSandog:fix/shell-path-guards-20260523
Open

fix: guard question log payload args#1665
hiSandog wants to merge 1 commit into
garrytan:mainfrom
hiSandog:fix/shell-path-guards-20260523

Conversation

@hiSandog
Copy link
Copy Markdown
Contributor

Summary

  • Add an explicit argument count check to gstack-question-log before reading $1 under set -u
  • Return a clear usage error when the JSON payload argument is missing
  • Add regression coverage for the missing-payload path

Tests

  • env PATH=/Users/sandog/.real/.bin:/opt/homebrew/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin /Users/sandog/.real/.bin/bun test test/gstack-question-log.test.ts
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant