Skip to content

Fix Codex browse runtime on Windows#1668

Open
Catfish-75 wants to merge 1 commit into
garrytan:mainfrom
Catfish-75:codex/windows-browse-runtime-fix
Open

Fix Codex browse runtime on Windows#1668
Catfish-75 wants to merge 1 commit into
garrytan:mainfrom
Catfish-75:codex/windows-browse-runtime-fix

Conversation

@Catfish-75
Copy link
Copy Markdown

Summary

  • install the browse runtime assets that the Codex skill needs on Windows, including browse/src, browse/bin, browse/dist, and externalized Node runtime packages
  • make browse stop handle shutdown before ensureServer() so a clean stop cannot cold-start a daemon
  • preserve cold-start command output on stdout and avoid delayed default startup banners after stop
  • add focused regression coverage for the Windows Codex dispatch/runtime setup path

Verification

  • bun test browse/test/config.test.ts
  • git diff --check -- browse/src/cli.ts browse/test/commands.test.ts browse/test/config.test.ts setup test/gen-skill-docs.test.ts
  • Installed Codex runtime smoke-tested from outside the repo with browse.exe stop, status, goto http://localhost:5173, snapshot -i, and final stop

Notes

Manual bun test browse/test/commands.test.ts still times out in the Windows BrowserManager/Playwright launch path. That file is already excluded from the curated Windows-safe shard as POSIX/Playwright-fragile, so this PR keeps the runtime fix focused instead of broadening the test harness change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant