Skip to content

feat(k8s): add configVersion annotation to pipeline deployments#326

Merged
fpacifici merged 1 commit into
mainfrom
fpacifici/annotation
May 21, 2026
Merged

feat(k8s): add configVersion annotation to pipeline deployments#326
fpacifici merged 1 commit into
mainfrom
fpacifici/annotation

Conversation

@fpacifici
Copy link
Copy Markdown
Collaborator

@fpacifici fpacifici commented May 21, 2026

Adding an annotation on the deployment that triggers a re-roll of the deployment when the configmap is changed.
This is the same pattern we have in snuba:
https://github.com/getsentry/ops/blob/master/k8s/services/snuba/_deployment.api.yaml.j2#L314

Summary

  • Add a configVersion pod template annotation containing the MD5 hash of pipeline_config serialized as JSON (same encoding as the ConfigMap).
  • Introduce compute_config_version() and wire it through _build_merged_pipeline_deployment() for primary and canary deployments.
  • Add a test asserting the annotation is set and merges with user-provided template annotations.

Made with Cursor

Add an MD5 hash of the JSON-serized pipeline_config as a pod template
annotation so deployments roll when the config changes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@fpacifici fpacifici requested a review from a team as a code owner May 21, 2026 17:54
@fpacifici fpacifici merged commit f66d765 into main May 21, 2026
25 checks passed
@fpacifici fpacifici deleted the fpacifici/annotation branch May 21, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants