Skip to content

Commit 1f3e948

Browse files
Copilotliuliu-dev
andcommitted
Fix CI failure by replacing broken chromium npm package with setup-chrome action
Co-authored-by: liuliu-dev <6688812+liuliu-dev@users.noreply.github.com>
1 parent f3e737f commit 1f3e948

4 files changed

Lines changed: 5 additions & 17 deletions

File tree

.github/workflows/nodejs.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,14 @@ jobs:
2121
uses: actions/setup-node@v4
2222
with:
2323
node-version: 22.x
24+
- name: Set up Chrome
25+
uses: browser-actions/setup-chrome@v1
26+
id: setup-chrome
2427
- name: npm install, build, and test
2528
run: |
2629
npm install
2730
npm run build --if-present
2831
npm test
2932
env:
3033
CI: true
34+
CHROME_BIN: ${{ steps.setup-chrome.outputs.chrome-path }}

karma.config.cjs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
process.env.CHROME_BIN = require('chromium').path
2-
31
module.exports = function (config) {
42
config.set({
53
frameworks: ['mocha', 'chai'],

package-lock.json

Lines changed: 1 addition & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
"devDependencies": {
2626
"@github/prettier-config": "0.0.4",
2727
"chai": "^4.2.0",
28-
"chromium": "^3.0.3",
2928
"eslint": "^6.8.0",
3029
"eslint-plugin-github": "^4.0.0",
3130
"karma": "^6.3.16",

0 commit comments

Comments
 (0)