[Bamboo] JDK_VERSION_MAPPING incorrectly maps Java 17, 18, 19 → "16" in actions/setup-java

[avowkind]

When migrating a Bamboo build plan that specifies jdk: JDK 17 (or JDK 18 / JDK 19) on a Maven, Ant, or Grails task, the generated workflow emits java-version: '16' instead of java-version: '17'. This causes builds to fail immediately with:

Fatal error compiling: error: invalid target release: 17

Root cause

The JDK_VERSION_MAPPING lookup table in lib/valet/transformers/utilities/java.rb (v1.3.22645) contains incorrect mappings for Java 17, 18, and 19:

JDK_VERSION_MAPPING = {
  ...
  "16" => "16",
  "17" => "16",   # should be "17"
  "18" => "16",   # should be "18" (or "17" as the nearest LTS)
  "19" => "16",   # should be "19" (or "17" as the nearest LTS)
}.freeze

Java 17 is an LTS release and has been in mainstream use since September 2021; mapping it to 16 is incorrect. The version() method also falls back to "16" for any unrecognised version, which compounds the problem for future releases.

To reproduce

Bamboo spec (--source-file-path):

Build and Deploy:
  key: JOB1
  tasks:
  - maven:
      executable: Maven
      jdk: JDK 17
      goal: clean package deploy

Command:

gh actions-importer dry-run bamboo build \
  --plan-slug MY-PLAN \
  --source-file-path path/to/plan.yaml \
  --output-dir ./output

Expected behaviour

Generated workflow contains:

- uses: actions/setup-java@v3
  with:
    distribution: zulu
    java-version: '17'

Actual behaviour

Generated workflow contains:

- uses: actions/setup-java@v3
  with:
    distribution: zulu
    java-version: '16'

Environment

gh actions-importer version	v1.3.22645
Docker image	ghcr.io/actions-importer/cli:latest (digest c7996b55b8e2)
Source CI	Bamboo
OS	macOS

Suggested fix

JDK_VERSION_MAPPING = {
  ...
  "16" => "16",
  "17" => "17",
  "18" => "18",
  "19" => "19",
  "21" => "21",
}.freeze

Alternatively, remove the mapping entirely for versions ≥ 17 and pass the parsed numeric version through verbatim, since actions/setup-java supports all modern Java versions directly.

Workaround

Use --custom-transformers with a Ruby file that overrides the Maven transformer to extract the version directly from the jdk: label string, bypassing JDK_VERSION_MAPPING:

transform "maven" do |item|
  jdk_label = item["jdk"].to_s
  version = jdk_label.match(/\d+/)&.to_s || "17"
  [
    {
      "name" => "Setup Java #{version}",
      "uses" => "actions/setup-java@v4.0.0",
      "with" => { "distribution" => "zulu", "java-version" => version }
    },
    { "name" => "Run Maven", "run" => "mvn #{item['goal']}" }
  ]
end