mock gh api client for tests

Author: skarim

cmd/push_test.go

@@ -7,6 +7,7 @@ import (
 
 	"github.com/github/gh-stack/internal/config"
 	"github.com/github/gh-stack/internal/git"
+	"github.com/github/gh-stack/internal/github"
 	"github.com/github/gh-stack/internal/stack"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -82,6 +83,7 @@ func TestPush_SkipPRs(t *testing.T) {
 	defer restore()
 
 	cfg, _, errR := config.NewTestConfig()
+	cfg.GitHubClientOverride = &github.MockClient{}
 	cmd := PushCmd(cfg)
 	cmd.SetArgs([]string{"--skip-prs"})
 	cmd.SetOut(io.Discard)
@@ -124,6 +126,7 @@ func TestPush_SkipsMergedBranches(t *testing.T) {
 	defer restore()
 
 	cfg, _, errR := config.NewTestConfig()
+	cfg.GitHubClientOverride = &github.MockClient{}
 	cmd := PushCmd(cfg)
 	cmd.SetArgs([]string{"--skip-prs"})
 	cmd.SetOut(io.Discard)
@@ -158,6 +161,7 @@ func TestPush_PushFailure(t *testing.T) {
 	defer restore()
 
 	cfg, _, errR := config.NewTestConfig()
+	cfg.GitHubClientOverride = &github.MockClient{}
 	cmd := PushCmd(cfg)
 	cmd.SetArgs([]string{"--skip-prs"})
 	cmd.SetOut(io.Discard)

cmd/unstack_test.go

@@ -8,6 +8,7 @@ import (
 
 	"github.com/github/gh-stack/internal/config"
 	"github.com/github/gh-stack/internal/git"
+	"github.com/github/gh-stack/internal/github"
 	"github.com/github/gh-stack/internal/stack"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -43,6 +44,7 @@ func TestUnstack_RemovesStack(t *testing.T) {
 	writeTwoStacks(t, gitDir, s1, s2)
 
 	cfg, outR, errR := config.NewTestConfig()
+	cfg.GitHubClientOverride = &github.MockClient{}
 	err := runUnstack(cfg, &unstackOptions{})
 	output := collectOutput(cfg, outR, errR)
 

internal/config/config.go

@@ -26,6 +26,10 @@ type Config struct {
 	ColorMagenta func(string) string
 	ColorCyan    func(string) string
 	ColorGray    func(string) string
+
+	// GitHubClientOverride, when non-nil, is returned by GitHubClient()
+	// instead of creating a real client. Used in tests to inject a MockClient.
+	GitHubClientOverride ghapi.ClientOps
 }
 
 // New creates a new Config with terminal-aware output and color support.
@@ -109,7 +113,10 @@ func (c *Config) Repo() (repository.Repository, error) {
 	return repository.Current()
 }
 
-func (c *Config) GitHubClient() (*ghapi.Client, error) {
+func (c *Config) GitHubClient() (ghapi.ClientOps, error) {
+	if c.GitHubClientOverride != nil {
+		return c.GitHubClientOverride, nil
+	}
 	repo, err := c.Repo()
 	if err != nil {
 		return nil, fmt.Errorf("determining repository: %w", err)