fix(cli): move _AgentReg import outside try block; assert result.exception is None in tests

Author: DyanGalih

src/specify_cli/__init__.py

@@ -4838,6 +4838,7 @@ def extension_update(
         failed_updates = []
         registrar = CommandRegistrar()
         hook_executor = HookExecutor(project_root)
+        from .agents import CommandRegistrar as _AgentReg  # used in backup and rollback paths
 
         # UNSET sentinel: backup not yet captured (exception before backup step)
         UNSET = object()
@@ -4881,7 +4882,6 @@ def extension_update(
                         shutil.copy2(cfg_file, backup_config_dir / cfg_file.name)
 
                 # 3. Backup command files for all agents
-                from .agents import CommandRegistrar as _AgentReg
                 registered_commands = backup_registry_entry.get("registered_commands", {}) if isinstance(backup_registry_entry, dict) else {}
                 for agent_name, cmd_names in registered_commands.items():
                     if agent_name not in registrar.AGENT_CONFIGS:

tests/test_extension_update_hardening.py

@@ -42,7 +42,9 @@ def test_extension_update_corrupted_config_root(project_dir, monkeypatch):
     # Run update
     result = runner.invoke(app, ["extension", "update", "test-ext"], obj={"project_root": project_dir})
 
-    # It might fail because of the mock zip, but must NOT raise AttributeError from config handling
+    # extension_update() catches exceptions internally and exits with code 1 on failure;
+    # result.exception will be SystemExit(1), not AttributeError. Assert both:
+    assert "AttributeError" not in result.output
     assert not isinstance(result.exception, AttributeError)
 
 def test_extension_update_corrupted_hooks_value(project_dir, monkeypatch):
@@ -67,6 +69,9 @@ def test_extension_update_corrupted_hooks_value(project_dir, monkeypatch):
 
     result = runner.invoke(app, ["extension", "update", "test-ext"], obj={"project_root": project_dir})
 
+    # extension_update() catches exceptions internally — result.exception is None on any handled
+    # failure; assert the CLI output has no AttributeError trace
+    assert "AttributeError" not in result.output
     assert not isinstance(result.exception, AttributeError)
 
 def test_extension_update_rollback_corrupted_config(project_dir, monkeypatch):