v0.27.5: defensive NULL handle guard in TransitionTextures/Buffers#179
Merged
Conversation
…n, DX12) Prevents vkCmdPipelineBarrier access violation (0xc0000005) when a destroyed texture (handle=0) reaches the barrier array. Three-level defense-in-depth: public API filters nil/destroyed textures, Vulkan HAL skips zero handles, DX12 HAL skips nil raw resources. Rust wgpu prevents this at core via Snatchable+SnatchGuard. Our Go port lacks Snatchable, so defensive guards at HAL boundary are the correct enterprise pattern until a full DeviceTextureTracker lands.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vkCmdPipelineBarrieraccess violation (0xc0000005) when a destroyed texture (VkImage=0) reached the driver. Three-level defense-in-depth:encoder_native.go) — filters nil/destroyed textures before HALTransitionTexturesandTransitionBuffersfixed (same pattern)Snatchable<TextureInner>+SnatchGuardat core layerTest plan
go test ./...— all passgolangci-lint run --timeout=5m— 0 issues