Merge pull request #6 from goobits/claude/lint-build-strict-uvwTr

Enforce strict TypeScript and improve code quality

Author: mudcube

docs/index.md

@@ -45,7 +45,7 @@ docs/
 New to docs-engine? Start here:
 
 - **[Getting Started](./getting-started.md)** - 5-minute setup guide
-- **[Installation](../README.md#installation)** - Package installation
+- **[Quick Start](../README.md#quick-start)** - Package installation
 
 ## Architecture Overview
 

eslint.config.js

@@ -47,10 +47,19 @@ export default [
       'no-implied-eval': 'error',
       'no-new-func': 'error',
 
-      // Code quality
-      '@typescript-eslint/explicit-function-return-type': 'warn',
+      // Code quality - STRICT mode
+      '@typescript-eslint/explicit-function-return-type': 'error',
       '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
-      '@typescript-eslint/no-explicit-any': 'warn',
+      '@typescript-eslint/no-explicit-any': 'error',
+      '@typescript-eslint/no-non-null-assertion': 'warn',
+
+      // Security rules - adjust for intentional patterns
+      // Object injection is safe when using typed objects with validated keys
+      'security/detect-object-injection': 'off',
+      // Non-literal regexp is intentional for search functionality
+      'security/detect-non-literal-regexp': 'off',
+      // Unsafe regex - we'll fix specific cases manually
+      'security/detect-unsafe-regex': 'warn',
     },
   },
   {

package.json

@@ -93,9 +93,9 @@
     }
   },
   "optionalDependencies": {
+    "@rollup/rollup-linux-arm64-gnu": "4.57.0",
     "chokidar": "^5.0.0",
-    "playwright": "^1.58.0",
-    "@rollup/rollup-linux-arm64-gnu": "4.53.2"
+    "playwright": "^1.58.0"
   },
   "keywords": [
     "sveltekit",
@@ -132,9 +132,8 @@
   "devDependencies": {
     "@eslint/js": "^9.39.2",
     "@testing-library/svelte": "^5.3.1",
-    "@types/dompurify": "^3.2.0",
     "@types/mdast": "^4.0.4",
-    "@types/node": "^25.0.10",
+    "@types/node": "^25.1.0",
     "@types/unist": "^3.0.3",
     "@typescript-eslint/eslint-plugin": "^8.54.0",
     "@typescript-eslint/parser": "^8.54.0",
@@ -144,14 +143,14 @@
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-security": "^3.0.1",
     "eslint-plugin-svelte": "^3.14.0",
-    "happy-dom": "^20.3.9",
+    "happy-dom": "^20.4.0",
     "husky": "^9.1.7",
     "jscpd": "^4.0.7",
     "lint-staged": "^16.2.7",
     "madge": "^8.0.0",
     "prettier": "^3.8.1",
     "prettier-plugin-svelte": "^3.4.1",
-    "svelte": "^5.48.2",
+    "svelte": "^5.48.5",
     "svelte-eslint-parser": "^1.4.1",
     "ts-morph": "^27.0.2",
     "tsup": "^8.5.1",

packages/docs-engine-cli/package.json

@@ -31,7 +31,7 @@
     "p-limit": "^7.2.0"
   },
   "devDependencies": {
-    "@types/node": "^25.0.10",
+    "@types/node": "^25.1.0",
     "@types/prompts": "^2.4.9",
     "tsup": "^8.5.1",
     "typescript": "^5.9.3"

packages/docs-engine-cli/src/link-checker.ts

@@ -282,8 +282,8 @@ async function checkExternalLink(
   cache: Map<string, LinkCheckResult>
 ): Promise<LinkCheckResult> {
   // Check cache first
-  if (cache.has(link.url)) {
-    const cached = cache.get(link.url)!;
+  const cached = cache.get(link.url);
+  if (cached) {
     return { ...cached, link };
   }
 

packages/docs-engine-cli/src/link-extractor.ts

@@ -114,7 +114,8 @@ export function extractLinksFromFile(filePath: string): ExtractedLink[] {
   });
 
   // Extract HTML links (basic regex for <a href="">)
-  const htmlLinkRegex = /<a\s+(?:[^>]*?\s+)?href=["']([^"']+)["']/gi;
+  // Use [^>]*? without nested \s+ to avoid catastrophic backtracking
+  const htmlLinkRegex = /<a\s[^>]*?href=["']([^"']+)["']/gi;
   const lines = content.split('\n');
 
   lines.forEach((lineContent, index) => {