Skip to content

git.github_pr_destination pr_branch parameter doesn't properly insert labels #317

@EliteMasterEric

Description

@EliteMasterEric

The PR branch parameter to the Github PR destination currently only supports the ${CONTEXT_REFERENCE}, and has no support for other labels.

As an example, I tried to use this configuration, to make the branch name clear.

    pr_branch = "public/copybara-${GITHUB_PR_USER}-${GITHUB_PR_NUMBER}",

However, instead of the intended result, I got public/copybara-public/copybara-__GITHUB_PR_USER_-public/copybara-__GITHUB_PR_USER_-__GITHUB_PR_NUMBER_-public/copybara-__GITHUB_PR_USER_-__GITHUB_PR_NUMBER_.

I believe the relevant code is located here:

.resolve(e -> e.equals("CONTEXT_REFERENCE") ? contextReference : prBranch);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions