fix: close packet channel on non-temporary errors#1236
Draft
leno23 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: wuyangfan <1102042793@qq.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PacketSource.Packets()whenNextPacketreturns an unknown non-temporary error instead of retrying forever.Unwrap-aware helper so wrapped errors are classified consistently without requiringerrors.Is(the module still declares Go 1.12).Packets()previously never closed after a persistent non-temporary read error.Packetsdocumentation to describe the non-temporary error behavior.Related Issues / Closes
Closes #1143
Testing
go test . -run TestPacketSourcePacketsClosesOnNonTemporaryError -count=1(passes)go test .(passes)go vet .(passes)git diff --check(passes)Additional validation:
go test ./...; it fails in unrelated platform/environment-dependent packages on this macOS runner:examples/afpacket: Linux-onlyafpacketbuild constraints exclude all Go files.pfring/examples/pfdump: missing system headerpfring.h.pcap:TestPCAPGoNgWritereportscould not read first packet: Read Error.AI assistance disclosure
This draft PR was prepared with AI assistance from Hermes Agent. I reviewed the issue context, implemented the minimal change, and ran the validation listed above.