Skip to content

fix: clean spaces from method_signatures#828

Merged
noahdietz merged 1 commit into
googleapis:mainfrom
noahdietz:fix-multi-sigs-with-spaces
Jun 8, 2026
Merged

fix: clean spaces from method_signatures#828
noahdietz merged 1 commit into
googleapis:mainfrom
noahdietz:fix-multi-sigs-with-spaces

Conversation

@noahdietz

Copy link
Copy Markdown
Collaborator

When a non-leading method_signature value has a space separating the comma-delimted values inside of the string, it produces an invalid method name e.g. "foo, bar" -> buildFoo Bar.

Remove all spaces from the method_signature value before using it name construction.

@noahdietz noahdietz marked this pull request as ready for review June 8, 2026 22:21
@noahdietz noahdietz requested a review from a team as a code owner June 8, 2026 22:21
@noahdietz noahdietz merged commit f679226 into googleapis:main Jun 8, 2026
14 checks passed
@noahdietz noahdietz deleted the fix-multi-sigs-with-spaces branch June 8, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants