minimal fix in fix_poms.py to exclude comments during extra module detection, preventing them from being

zhumin8 · zhumin8 · commit 45f17c41dfa4 · 2026-05-26T16:19:39.000-04:00
converted into broken tags

fix lint
diff --git a/sdk-platform-java/hermetic_build/library_generation/owlbot/src/fix_poms.py b/sdk-platform-java/hermetic_build/library_generation/owlbot/src/fix_poms.py
@@ -219,7 +219,9 @@ def update_parent_pom(filename: str, modules: List[module.Module]):
 
     module_names = [m.artifact_id for m in modules]
     extra_modules = [
-        m.text for i, m in enumerate(existing) if m.text not in module_names
+        m.text
+        for i, m in enumerate(existing)
+        if m.tag != etree.Comment and m.text not in module_names
     ]
 
     modules_to_write = module_names + extra_modules

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,9 @@ def update_parent_pom(filename: str, modules: List[module.Module]):`
`219`	`219`
`220`	`220`	`module_names = [m.artifact_id for m in modules]`
`221`	`221`	`extra_modules = [`
`222`		`- m.text for i, m in enumerate(existing) if m.text not in module_names`
	`222`	`+ m.text`
	`223`	`+ for i, m in enumerate(existing)`
	`224`	`+ if m.tag != etree.Comment and m.text not in module_names`
`223`	`225`	`]`
`224`	`226`
`225`	`227`	`modules_to_write = module_names + extra_modules`