Commit 5efbb46
authored
chore: always run units jobs with step-level skips (#13326)
### Description
This PR solves the issue where required checks `units (11)`, `units
(17)`, `units (21)`, `units (25)`, and `units (8)` get stuck in a
pending "stuck forever" state on GitHub.
For example, https://screenshot.googleplex.com/9bpNwWP7jParbuM
### Root Cause
The `units` and `units-8-runtime` jobs in `.github/workflows/ci.yaml`
are conditionally skipped using job-level `if: ${{
needs.bulk-filter.outputs.runnable == 'true' }}`.
Because the entire job is skipped at the job-level, the matrix versions
are not expanded, and status checks like `units (11)` are never reported
to GitHub. When these checks are configured directly as required status
checks in branch protection rules, PRs that skip the jobs (e.g.,
workflow-only PRs) are stuck forever.
### Solution
We removed the job-level `if: runnable == true` conditional from both
`units` and `units-8-runtime` jobs so they always start. Instead, we
applied the `if: runnable == true` check to every individual step inside
these jobs.
When a PR doesn't need to run these checks:
1. The jobs will still start and run.
2. All steps will skip instantly.
3. The jobs will finish successfully in 1–2 seconds, reporting success
and satisfying GitHub's required status checks.1 parent 98d8e69 commit 5efbb46
1 file changed
Lines changed: 13 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
63 | 62 | | |
64 | 63 | | |
65 | 64 | | |
66 | 65 | | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
| 69 | + | |
69 | 70 | | |
| 71 | + | |
70 | 72 | | |
71 | 73 | | |
72 | 74 | | |
73 | 75 | | |
| 76 | + | |
74 | 77 | | |
75 | 78 | | |
| 79 | + | |
76 | 80 | | |
77 | 81 | | |
78 | 82 | | |
79 | 83 | | |
80 | | - | |
| 84 | + | |
81 | 85 | | |
82 | 86 | | |
83 | 87 | | |
84 | 88 | | |
85 | 89 | | |
86 | 90 | | |
87 | | - | |
88 | 91 | | |
89 | 92 | | |
90 | 93 | | |
91 | 94 | | |
| 95 | + | |
92 | 96 | | |
93 | 97 | | |
| 98 | + | |
94 | 99 | | |
| 100 | + | |
95 | 101 | | |
96 | 102 | | |
97 | 103 | | |
98 | 104 | | |
99 | 105 | | |
100 | 106 | | |
| 107 | + | |
101 | 108 | | |
102 | 109 | | |
103 | 110 | | |
| 111 | + | |
104 | 112 | | |
105 | 113 | | |
106 | 114 | | |
107 | 115 | | |
108 | 116 | | |
109 | 117 | | |
| 118 | + | |
110 | 119 | | |
111 | 120 | | |
112 | 121 | | |
113 | 122 | | |
114 | | - | |
| 123 | + | |
115 | 124 | | |
116 | 125 | | |
117 | 126 | | |
| |||
0 commit comments