From 822eea146e8288c8d273d66e54935521b9c469b2 Mon Sep 17 00:00:00 2001 From: Will Howes Date: Thu, 21 May 2026 02:21:02 +0000 Subject: [PATCH 1/3] test(compute): simplify and re-enable flaky ITPaginationTest test case --- .../compute/v1/integration/ITPaginationTest.java | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java b/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java index 50ee2cd56eb8..99fa8e261f94 100644 --- a/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java +++ b/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java @@ -30,7 +30,6 @@ import org.junit.AfterClass; import org.junit.Assert; import org.junit.BeforeClass; -import org.junit.Ignore; import org.junit.Test; public class ITPaginationTest extends BaseTest { @@ -112,25 +111,19 @@ public void testPaginationNextToken() { Lists.newArrayList(Iterables.transform(nextPageWithToken.getValues(), Zone::getName))); } - @Ignore(value = "https://github.com/googleapis/google-cloud-java/issues/11759") @Test public void testPaginationIterating() { ListZonesRequest listZonesRequest = ListZonesRequest.newBuilder().setProject(DEFAULT_PROJECT).setMaxResults(1).build(); ZonesClient.ListPagedResponse response = zonesClient.list(listZonesRequest); - boolean presented = false; int count = 0; for (Zone element : response.iterateAll()) { + Assert.assertNotNull(element.getName()); count++; - if (element.getName().equals(DEFAULT_ZONE)) { - presented = true; - } } Assert.assertTrue( - String.format( - "Zone %s was not found for %s in zones list (size: %d).", - DEFAULT_ZONE, DEFAULT_PROJECT, count), - presented); + "Expected iterator to traverse multiple pages", + count >= 2); } @Test From cefe7e961e0dfbe089947fae0232263ce73f760e Mon Sep 17 00:00:00 2001 From: Will Howes Date: Thu, 28 May 2026 17:43:02 +0000 Subject: [PATCH 2/3] test(compute): apply gemini-code-assist suggestion --- .../google/cloud/compute/v1/integration/ITPaginationTest.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java b/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java index 99fa8e261f94..e65fe4ab29f7 100644 --- a/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java +++ b/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java @@ -120,6 +120,9 @@ public void testPaginationIterating() { for (Zone element : response.iterateAll()) { Assert.assertNotNull(element.getName()); count++; + if (count >= 2) { + break; + } } Assert.assertTrue( "Expected iterator to traverse multiple pages", From 096d74b416b657fbd5840d75051091a4cf9e4fa3 Mon Sep 17 00:00:00 2001 From: Will Howes Date: Thu, 28 May 2026 17:57:00 +0000 Subject: [PATCH 3/3] fix linter errors --- .../google/cloud/compute/v1/integration/ITPaginationTest.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java b/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java index e65fe4ab29f7..9c242b02cf1f 100644 --- a/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java +++ b/java-compute/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/integration/ITPaginationTest.java @@ -124,9 +124,7 @@ public void testPaginationIterating() { break; } } - Assert.assertTrue( - "Expected iterator to traverse multiple pages", - count >= 2); + Assert.assertTrue("Expected iterator to traverse multiple pages", count >= 2); } @Test