From e0eead00cca936719f651fd8e81f50d72537d761 Mon Sep 17 00:00:00 2001
From: Alan Baker <alanbaker@google.com>
Date: Tue, 21 Jul 2026 12:53:55 -0400
Subject: [PATCH] Fix buffer_view validation tests

* bufferView and bufferArrayView tests had invalid checks for the
  parameter type tests (copypasta)
---
 .../expression/call/builtin/bufferArrayView.spec.ts  | 12 ++++--------
 .../expression/call/builtin/bufferView.spec.ts       |  6 ++----
 2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/src/webgpu/shader/validation/expression/call/builtin/bufferArrayView.spec.ts b/src/webgpu/shader/validation/expression/call/builtin/bufferArrayView.spec.ts
index aa6ee202cdd3..1bc51968ef5f 100644
--- a/src/webgpu/shader/validation/expression/call/builtin/bufferArrayView.spec.ts
+++ b/src/webgpu/shader/validation/expression/call/builtin/bufferArrayView.spec.ts
@@ -135,11 +135,9 @@ g.test('offset_type')
   .desc('Validates the offset parameter type')
   .params(u => u.combine('type', keysOf(kTypes)))
   .fn(t => {
+    t.skipIfLanguageFeatureNotSupported('buffer_view');
     const type = kTypes[t.params.type];
-    let enables = `enable subgroups;\n`;
-    if (type.requiresF16()) {
-      enables += `enable f16;`;
-    }
+    const enables = type.requiresF16() ? 'enable f16;' : '';
     const wgsl = `
 ${enables}
 @group(0) @binding(0) var<storage> v : buffer;
@@ -158,11 +156,9 @@ g.test('size_type')
   .desc('Validates the offset parameter type')
   .params(u => u.combine('type', keysOf(kTypes)))
   .fn(t => {
+    t.skipIfLanguageFeatureNotSupported('buffer_view');
     const type = kTypes[t.params.type];
-    let enables = `enable subgroups;\n`;
-    if (type.requiresF16()) {
-      enables += `enable f16;`;
-    }
+    const enables = type.requiresF16() ? 'enable f16;' : '';
     const wgsl = `
 ${enables}
 @group(0) @binding(0) var<storage> v : buffer;
diff --git a/src/webgpu/shader/validation/expression/call/builtin/bufferView.spec.ts b/src/webgpu/shader/validation/expression/call/builtin/bufferView.spec.ts
index 50dbf120805c..f90a784587a9 100644
--- a/src/webgpu/shader/validation/expression/call/builtin/bufferView.spec.ts
+++ b/src/webgpu/shader/validation/expression/call/builtin/bufferView.spec.ts
@@ -129,11 +129,9 @@ g.test('offset_type')
   .desc('Validates the offset parameter type')
   .params(u => u.combine('type', keysOf(kTypes)))
   .fn(t => {
+    t.skipIfLanguageFeatureNotSupported('buffer_view');
     const type = kTypes[t.params.type];
-    let enables = `enable subgroups;\n`;
-    if (type.requiresF16()) {
-      enables += `enable f16;`;
-    }
+    const enables = type.requiresF16() ? 'enable f16;' : '';
     const wgsl = `
 ${enables}
 @group(0) @binding(0) var<storage> v : buffer;