-
Notifications
You must be signed in to change notification settings - Fork 35
DCAR: Toggle Display Of Ad Placeholders In Development #10170
Copy link
Copy link
Open
Labels
Interactives 📈Pick me upsmall effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…Team Candidate: WebXmaintenanceDepartmental tracking: maintenance work, not a fix or a featureDepartmental tracking: maintenance work, not a fix or a feature
Milestone
Metadata
Metadata
Assignees
Labels
Interactives 📈Pick me upsmall effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…small effort, self contained issues to do when you feel like a pick me up, waiting to be unblocked…Team Candidate: WebXmaintenanceDepartmental tracking: maintenance work, not a fix or a featureDepartmental tracking: maintenance work, not a fix or a feature
Type
Fields
Give feedbackNo fields configured for issues without a type.
By default we don't show the ad placeholders that are used to insert ads; we only display them if we're able to check with the native layer that the user is not premium.
dotcom-rendering/dotcom-rendering/src/components/AdPortals.importable.tsx
Lines 130 to 155 in 8901550
As a result, when viewing DCAR in a browser for development purposes you will never see the ad placeholders, because there is no native layer to query.
However, sometimes it's useful to be able to see these placeholders outside of the app. For example, when interactive developers (Design, Visuals) are building interactives they would like to be able to see them, to make sure they can work around them correctly.
We discussed coming up with a mechanism for toggling the placeholders on and off for development purposes, possibly with a query parameter. Ideally this parameter would work in preview.