[Breaking] Rename callback setters to setCallbacks, taking a reference only

Author: h2zero

examples/ANCS/ANCS.ino

@@ -120,7 +120,7 @@ void setup() {
     NimBLEDevice::setPower(9);
 
     NimBLEServer* pServer = NimBLEDevice::createServer();
-    pServer->setCallbacks(&serverCallbacks);
+    pServer->setCallbacks(serverCallbacks);
     pServer->advertiseOnDisconnect(true);
 
     NimBLEAdvertising*      pAdvertising = pServer->getAdvertising();

examples/BLE_Beacon_Scanner/BLE_Beacon_Scanner.ino

@@ -81,7 +81,7 @@ void setup() {
 
     NimBLEDevice::init("Beacon-scanner");
     pBLEScan = BLEDevice::getScan();
-    pBLEScan->setScanCallbacks(&scanCallbacks);
+    pBLEScan->setCallbacks(scanCallbacks);
     pBLEScan->setActiveScan(true);
     pBLEScan->setInterval(100);
     pBLEScan->setWindow(100);

examples/Bluetooth_5/NimBLE_extended_client/NimBLE_extended_client.ino

@@ -57,7 +57,7 @@ bool connectToServer() {
     NimBLEClient* pClient = nullptr;
 
     pClient = NimBLEDevice::createClient();
-    pClient->setClientCallbacks(&clientCallbacks, false);
+    pClient->setCallbacks(clientCallbacks);
 
     /**
      * Set the PHY's to use for this connection. This is a bitmask that represents the PHY's:
@@ -112,7 +112,7 @@ void setup() {
 
     /** Create aNimBLE Scan instance and set the callbacks for scan events */
     NimBLEScan* pScan = NimBLEDevice::getScan();
-    pScan->setScanCallbacks(&scanCallbacks);
+    pScan->setCallbacks(scanCallbacks);
 
     /** Set scan interval (how often) and window (how long) in milliseconds */
     pScan->setInterval(97);

examples/Bluetooth_5/NimBLE_extended_scan/NimBLE_extended_scan.ino

@@ -60,7 +60,7 @@ void setup() {
     NimBLEScan* pScan = NimBLEDevice::getScan();
 
     /** Set the callbacks that the scanner will call on events. */
-    pScan->setScanCallbacks(&scanCallbacks);
+    pScan->setCallbacks(scanCallbacks);
 
     /** Use active scanning to obtain scan response data from advertisers */
     pScan->setActiveScan(true);

examples/Bluetooth_5/NimBLE_extended_server/NimBLE_extended_server.ino

@@ -89,7 +89,7 @@ void setup() {
 
     /** Create the server and add the services/characteristics/descriptors */
     NimBLEServer* pServer = NimBLEDevice::createServer();
-    pServer->setCallbacks(&serverCallbacks);
+    pServer->setCallbacks(serverCallbacks);
 
     NimBLEService*        pService = pServer->createService(SERVICE_UUID);
     NimBLECharacteristic* pCharacteristic =
@@ -125,7 +125,7 @@ void setup() {
     NimBLEExtAdvertising* pAdvertising = NimBLEDevice::getAdvertising();
 
     /** Set the callbacks for advertising events */
-    pAdvertising->setCallbacks(&advertisingCallbacks);
+    pAdvertising->setCallbacks(advertisingCallbacks);
 
     /**
      *  NimBLEExtAdvertising::setInstanceData takes the instance ID and

examples/Bluetooth_5/NimBLE_multi_advertiser/NimBLE_multi_advertiser.ino

@@ -107,7 +107,7 @@ void setup() {
 
     /** Create a server for our legacy advertiser */
     NimBLEServer* pServer = NimBLEDevice::createServer();
-    pServer->setCallbacks(&serverCallbacks);
+    pServer->setCallbacks(serverCallbacks);
 
     NimBLEService*        pService = pServer->createService(SERVICE_UUID);
     NimBLECharacteristic* pCharacteristic =
@@ -155,7 +155,7 @@ void setup() {
     NimBLEExtAdvertising* pAdvertising = NimBLEDevice::getAdvertising();
 
     /** Set the callbacks to handle advertising events */
-    pAdvertising->setCallbacks(&advCallbacks);
+    pAdvertising->setCallbacks(advCallbacks);
 
     /**
      *  Set instance data.

examples/L2CAP/L2CAP_Client/L2CAP_Client.ino

@@ -86,7 +86,7 @@ void setup() {
     NimBLEDevice::setMTU(BLE_ATT_MTU_MAX);
 
     auto scan = NimBLEDevice::getScan();
-    scan->setScanCallbacks(&scanCallbacks);
+    scan->setCallbacks(scanCallbacks);
     scan->setInterval(1349);
     scan->setWindow(449);
     scan->setActiveScan(true);
@@ -106,7 +106,7 @@ void loop() {
     if (!theClient) {
         theClient = NimBLEDevice::createClient();
         theClient->setConnectionParams(6, 6, 0, 42);
-        theClient->setClientCallbacks(&clientCallbacks);
+        theClient->setCallbacks(clientCallbacks);
         if (!theClient->connect(theDevice)) {
             Serial.println("Error: Could not connect to device");
             return;

examples/L2CAP/L2CAP_Server/L2CAP_Server.ino

@@ -65,7 +65,7 @@ void setup() {
     auto channel   = cocServer->createService(L2CAP_CHANNEL, L2CAP_MTU, &l2capCallbacks);
 
     auto server = NimBLEDevice::createServer();
-    server->setCallbacks(&gattCallbacks);
+    server->setCallbacks(gattCallbacks);
 
     auto service        = server->createService(SERVICE_UUID);
     auto characteristic = service->createCharacteristic(CHARACTERISTIC_UUID, NIMBLE_PROPERTY::READ);

examples/NimBLE_Async_Client/NimBLE_Async_Client.ino

@@ -40,7 +40,7 @@ class ScanCallbacks : public NimBLEScanCallbacks {
                 }
             }
 
-            pClient->setClientCallbacks(&clientCallbacks, false);
+            pClient->setCallbacks(clientCallbacks);
             if (!pClient->connect(true, true, false)) { // delete attributes, async connect, no MTU exchange
                 NimBLEDevice::deleteClient(pClient);
                 Serial.printf("Failed to connect\n");
@@ -62,7 +62,7 @@ void setup() {
     NimBLEDevice::setPower(3); /** +3db */
 
     NimBLEScan* pScan = NimBLEDevice::getScan();
-    pScan->setScanCallbacks(&scanCallbacks);
+    pScan->setCallbacks(scanCallbacks);
     pScan->setInterval(45);
     pScan->setWindow(45);
     pScan->setActiveScan(true);

examples/NimBLE_Client/NimBLE_Client.ino

@@ -122,7 +122,7 @@ bool connectToServer() {
 
         Serial.printf("New client created\n");
 
-        pClient->setClientCallbacks(&clientCallbacks, false);
+        pClient->setCallbacks(clientCallbacks);
         /**
          *  Set initial connection parameters:
          *  These settings are safe for 3 clients to connect reliably, can go faster if you have less
@@ -273,7 +273,7 @@ void setup() {
     NimBLEScan* pScan = NimBLEDevice::getScan();
 
     /** Set the callbacks to call when scan events occur, no duplicates */
-    pScan->setScanCallbacks(&scanCallbacks, false);
+    pScan->setCallbacks(scanCallbacks, false);
 
     /** Set scan interval (how often) and window (how long) in milliseconds */
     pScan->setInterval(100);