From 5139ff8e52ab91c1185da53076d70c345b5f95af Mon Sep 17 00:00:00 2001 From: Aaron Zeng Date: Thu, 5 Feb 2026 12:28:24 -0500 Subject: [PATCH] Do not redefine xref-prompt-for-identifier MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The correct way to declare a variable as dynamically bound but defined elsewhere is to use defvar with a variable name but no value. Otherwise, this causes the following unwanted side-effect when pressing `C-h v xref-prompt-for-identifier`: ``` xref-prompt-for-identifier is a variable defined in ‘haskell.el’. ``` --- haskell.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/haskell.el b/haskell.el index 33e7ac7b..efd0ae48 100644 --- a/haskell.el +++ b/haskell.el @@ -324,7 +324,7 @@ If `haskell-process-load-or-reload-prompt' is nil, accept `default'." (haskell-interactive-mode-error-backward) (haskell-interactive-jump-to-error-line))))) -(defvar xref-prompt-for-identifier nil) +(defvar xref-prompt-for-identifier) ;;;###autoload (defun haskell-mode-jump-to-tag (&optional next-p)