Move matplotlib from core dependencies to docs/test extras#2
Merged
henrydingliu merged 1 commit intoMay 10, 2026
Merged
Conversation
Closes casact#758 matplotlib is only used in docs/gallery example notebooks; no source file under chainladder/ imports it (the references in chainladder/core/display.py are docstring-only). - Removed matplotlib from [project] dependencies. - Added matplotlib to docs extra (used by gallery notebooks). - Added matplotlib to test extra (nbmake exercises the gallery notebooks).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes casact#758
matplotlib is only used in docs/gallery example notebooks; no source file under chainladder/ imports it (the references in chainladder/core/display.py are docstring-only).
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)