Skip to content

Move matplotlib from core dependencies to docs/test extras#2

Merged
henrydingliu merged 1 commit into
henrydingliu:resettingfrom
SaguaroDev:758-matplotlib-to-docs
May 10, 2026
Merged

Move matplotlib from core dependencies to docs/test extras#2
henrydingliu merged 1 commit into
henrydingliu:resettingfrom
SaguaroDev:758-matplotlib-to-docs

Conversation

@henrydingliu
Copy link
Copy Markdown
Owner

Closes casact#758

matplotlib is only used in docs/gallery example notebooks; no source file under chainladder/ imports it (the references in chainladder/core/display.py are docstring-only).

  • Removed matplotlib from [project] dependencies.
  • Added matplotlib to docs extra (used by gallery notebooks).
  • Added matplotlib to test extra (nbmake exercises the gallery notebooks).

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

  • I passed tests locally for both code (pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Closes casact#758

matplotlib is only used in docs/gallery example notebooks; no source
file under chainladder/ imports it (the references in
chainladder/core/display.py are docstring-only).

- Removed matplotlib from [project] dependencies.
- Added matplotlib to docs extra (used by gallery notebooks).
- Added matplotlib to test extra (nbmake exercises the gallery
  notebooks).
@henrydingliu henrydingliu merged commit 31ee55c into henrydingliu:resetting May 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants