Sanitize control characters in transport fallback errors

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -50,8 +50,12 @@ def _safe_to_string(value: Any) -> str:
         normalized_value = str(value)
     except Exception:
         return f"<unstringifiable {type(value).__name__}>"
-    if normalized_value.strip():
-        return normalized_value
+    sanitized_value = "".join(
+        "?" if ord(character) < 32 or ord(character) == 127 else character
+        for character in normalized_value
+    )
+    if sanitized_value.strip():
+        return sanitized_value
     return f"<{type(value).__name__}>"
 
 

tests/test_transport_error_utils.py

@@ -158,6 +158,11 @@ def __str__(self) -> str:
         return "   "
 
 
+class _ControlFallbackError(Exception):
+    def __str__(self) -> str:
+        return "bad\tfallback\ntext"
+
+
 class _BrokenFallbackResponse:
     @property
     def text(self) -> str:
@@ -742,6 +747,14 @@ def test_extract_error_message_uses_placeholder_for_blank_fallback_error_text():
     assert message == "<_BlankFallbackError>"
 
 
+def test_extract_error_message_sanitizes_control_characters_in_fallback_error_text():
+    message = extract_error_message(
+        _DummyResponse("   ", text="   "), _ControlFallbackError()
+    )
+
+    assert message == "bad?fallback?text"
+
+
 def test_extract_error_message_extracts_errors_list_messages():
     message = extract_error_message(
         _DummyResponse({"errors": [{"msg": "first issue"}, {"msg": "second issue"}]}),