Normalize client timeout values to float before transport assignment

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/async_client.py

@@ -27,7 +27,7 @@ def __init__(
         headers: Optional[Mapping[str, str]] = None,
         timeout: Optional[float] = 30,
     ):
-        validate_timeout_seconds(timeout)
+        timeout = validate_timeout_seconds(timeout)
         super().__init__(AsyncTransport, config, api_key, base_url, headers)
         self.transport.client.timeout = timeout
         self.sessions = SessionManager(self)

hyperbrowser/client/sync.py

@@ -27,7 +27,7 @@ def __init__(
         headers: Optional[Mapping[str, str]] = None,
         timeout: Optional[float] = 30,
     ):
-        validate_timeout_seconds(timeout)
+        timeout = validate_timeout_seconds(timeout)
         super().__init__(SyncTransport, config, api_key, base_url, headers)
         self.transport.client.timeout = timeout
         self.sessions = SessionManager(self)

hyperbrowser/client/timeout_utils.py

@@ -5,16 +5,21 @@
 from ..exceptions import HyperbrowserError
 
 
-def validate_timeout_seconds(timeout: Optional[float]) -> None:
+def validate_timeout_seconds(timeout: Optional[float]) -> Optional[float]:
     if timeout is None:
-        return
+        return None
     if isinstance(timeout, bool) or not isinstance(timeout, Real):
         raise HyperbrowserError("timeout must be a number")
     try:
-        is_finite = math.isfinite(timeout)
+        normalized_timeout = float(timeout)
+    except (TypeError, ValueError, OverflowError) as exc:
+        raise HyperbrowserError("timeout must be finite") from exc
+    try:
+        is_finite = math.isfinite(normalized_timeout)
     except (TypeError, ValueError, OverflowError):
         is_finite = False
     if not is_finite:
         raise HyperbrowserError("timeout must be finite")
-    if timeout < 0:
+    if normalized_timeout < 0:
         raise HyperbrowserError("timeout must be non-negative")
+    return normalized_timeout

tests/test_client_timeout.py

@@ -31,6 +31,33 @@ async def run() -> None:
     asyncio.run(run())
 
 
+def test_sync_client_normalizes_fraction_timeout_to_float():
+    client = Hyperbrowser(
+        api_key="test-key",
+        timeout=Fraction(1, 2),  # type: ignore[arg-type]
+    )
+    try:
+        assert isinstance(client.transport.client.timeout.connect, float)
+        assert client.transport.client.timeout.connect == 0.5
+    finally:
+        client.close()
+
+
+def test_async_client_normalizes_fraction_timeout_to_float():
+    async def run() -> None:
+        client = AsyncHyperbrowser(
+            api_key="test-key",
+            timeout=Fraction(1, 2),  # type: ignore[arg-type]
+        )
+        try:
+            assert isinstance(client.transport.client.timeout.connect, float)
+            assert client.transport.client.timeout.connect == 0.5
+        finally:
+            await client.close()
+
+    asyncio.run(run())
+
+
 def test_sync_client_rejects_non_numeric_timeout():
     with pytest.raises(HyperbrowserError, match="timeout must be a number"):
         Hyperbrowser(api_key="test-key", timeout="30")  # type: ignore[arg-type]